Merge lp:~seb128/apturl/dont-decode-str into lp:apturl
Proposed by
Sebastien Bacher
Status: | Merged |
---|---|
Merged at revision: | 135 |
Proposed branch: | lp:~seb128/apturl/dont-decode-str |
Merge into: | lp:apturl |
Diff against target: |
12 lines (+1/-1) 1 file modified
AptUrl/AptUrl.py (+1/-1) |
To merge this branch: | bzr merge lp:~seb128/apturl/dont-decode-str |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Steve Langasek | Approve | ||
Brian Murray | Pending | ||
Michael Vogt | Pending | ||
Ubuntu Core Development Team | Pending | ||
Review via email: mp+197804@code.launchpad.net |
Commit message
don't use decode on a str
Description of the change
don't use decode on a str
To post a comment you must log in.
The issue there is that "decode" is being use on a str type, which doesn't work
looking through the history bazaar. launchpad. net/~ubuntu- core-dev/ apturl/ ubuntu/ revision/ 118 bazaar. launchpad. net/~ubuntu- core-dev/ apturl/ ubuntu/ revision/ 120
r118, Steve added the decode, the variable was a an "unicode" type, http://
r120, Brian ported to python3, changing the type to a "str" but keeping the decode, http://
The issue is trivial to trigger, just call "apturl-gtk /local/dir/binary"
The change fixes the assertion, not sure if the utf8 handling is an issue with python3 though, or if that's adding back the issue Steve was solving (there is no bug reference on that commit) ... review from people who know how python2/3 handle encodings would be welcome