Code review comment for ~sdeziel/apparmor-profiles/+git/apparmor-profiles:thunderbird-icedove-debian

Steve Beattie (sbeattie) wrote :

Thanks. I merged this as-is (and appreciate the followup commit that maintained the merged usr where appropriate). I did raise an eyebrow at

+ # other commonly used locations
+ /{data,media,mnt,srv}/** r,
+ owner /{data,media,mnt,srv}/** rw,

in that for /srv/ I personally tend to place system service data files there, rather than user data files... but I can see that not being the case for other environments.

Also, at some point, we should try to identify if the accesses to /proc/[0-9]* are to its own pid (or likely for the thunderbird crash reporter), for different pids, and use @{pid} and @{pids} accordingly.

Thanks again!

review: Approve

« Back to merge proposal