Merge lp:~scigghia/openobject-italia/riba_v7_scigghia_2 into lp:~openobject-italia-core-devs/openobject-italia/italian-addons-7.0

Proposed by Andrea Cometa
Status: Merged
Merged at revision: 236
Proposed branch: lp:~scigghia/openobject-italia/riba_v7_scigghia_2
Merge into: lp:~openobject-italia-core-devs/openobject-italia/italian-addons-7.0
Diff against target: 60 lines (+17/-1)
2 files modified
l10n_it_ricevute_bancarie/riba.py (+16/-1)
l10n_it_ricevute_bancarie/riba_view.xml (+1/-0)
To merge this branch: bzr merge lp:~scigghia/openobject-italia/riba_v7_scigghia_2
Reviewer Review Type Date Requested Status
Lorenzo Battistini code review Approve
Francesco Apruzzese (community) Approve
giudalo (community) Approve
andrea_cg (community) Approve
Review via email: mp+208602@code.launchpad.net

This proposal supersedes a proposal from 2014-02-27.

Description of the change

[resubmit]
in questo branch ho aggiunto il campo data registrazione, da propagare in account.move all'accettazione della distinta.
inoltre è presente un controllo sulla presenza del conto accettazione, senza il quale l'accettazione della distinta causa errore se la configurazione della riba viene modificata da "dopo incasso" a "sbf" dopo aver emesso la distinta

To post a comment you must log in.
Revision history for this message
Lorenzo Battistini (elbati) wrote : Posted in a previous version of this proposal

Il target branch è stato mergiato.
Conviene impostare lp:openobject-italia/7.0 come target

review: Needs Resubmitting
Revision history for this message
andrea_cg (a-gallina) wrote :

ok!

review: Approve
Revision history for this message
Andrea Cometa (scigghia) wrote :

già fatto

Revision history for this message
giudalo (g-dalo) wrote :

ho provato e funziona, ma non è chiaro cosa fa !!

review: Approve
Revision history for this message
Francesco Apruzzese (opencode) :
review: Approve
Revision history for this message
Lorenzo Battistini (elbati) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'l10n_it_ricevute_bancarie/riba.py'
2--- l10n_it_ricevute_bancarie/riba.py 2013-12-16 15:22:58 +0000
3+++ l10n_it_ricevute_bancarie/riba.py 2014-02-27 13:44:47 +0000
4@@ -92,6 +92,14 @@
5 'payment_ids': fields.function(_get_payment_ids, relation='account.move.line', type="many2many", string='Payments'),
6 'unsolved_move_ids': fields.function(_get_unsolved_move_ids, type='many2many', relation='account.move', method=True, string="Unsolved Entries"),
7 'type': fields.related('config', 'tipo', type='char', size=32, string='Type', readonly=True),
8+ 'registration_date': fields.date(
9+ 'Registration Date',
10+ states={'draft': [('readonly', False)],
11+ 'cancel': [('readonly', False)], },
12+ select=True,
13+ readonly=True,
14+ required=True,
15+ help="Keep empty to use the current date"),
16 }
17
18 _defaults = {
19@@ -99,6 +107,7 @@
20 'date_created': fields.date.context_today,
21 'name': lambda self,cr,uid,context: self.pool.get('ir.sequence').get(cr, uid, 'riba.distinta'),
22 'company_id': lambda self,cr,uid,c: self.pool.get('res.company')._company_default_get(cr, uid, 'riba.distinta', context=c),
23+ 'registration_date': fields.date.context_today,
24 }
25
26 def unlink(self, cr, uid, ids, context=None):
27@@ -357,6 +366,7 @@
28 move_id= move_pool.create(cr, uid, {
29 'ref': 'Ri.Ba. %s - line %s' % (line.distinta_id.name, line.sequence),
30 'journal_id': journal.id,
31+ 'date': line.distinta_id.registration_date,
32 }, context=context)
33 to_be_reconciled = []
34 for riba_move_line in line.move_line_ids:
35@@ -372,7 +382,12 @@
36 to_be_reconciled.append([move_line_id, riba_move_line.move_line_id.id])
37 move_line_pool.create(cr, uid, {
38 'name': 'Ri.Ba. %s - line %s' % (line.distinta_id.name, line.sequence),
39- 'account_id': line.acceptance_account_id.id,
40+ 'account_id': (
41+ line.acceptance_account_id.id or
42+ line.distinta_id.config.acceptance_account_id.id
43+ # in questo modo se la riga non ha conto accettazione
44+ # viene prelevato il conto in configurazione riba
45+ ),
46 'partner_id': line.partner_id.id,
47 'date_maturity': line.due_date,
48 'credit': 0.0,
49
50=== modified file 'l10n_it_ricevute_bancarie/riba_view.xml'
51--- l10n_it_ricevute_bancarie/riba_view.xml 2013-11-09 12:43:20 +0000
52+++ l10n_it_ricevute_bancarie/riba_view.xml 2014-02-27 13:44:47 +0000
53@@ -51,6 +51,7 @@
54 <form string="Ri.Ba. - Distinta">
55 <field name="name" />
56 <field name="config" widget="selection"/>
57+ <field name="registration_date" />
58 <notebook colspan="4">
59 <page string="General">
60 <field name="line_ids" nolabel="1" colspan="4">

Subscribers

People subscribed via source and target branches