Code review comment for lp:~schwieni/inkscape/inkscape

> You are right. I just followed the interface definition of the ::get
method, which doesn't use those arguments neither (but possibly for
future use/ usage in the past, I don't know). However, since I have no
personal preference to it, this can be changed. Should I change it?

Never mind. I just looked in the Inkscape source code and all code is written exactly that way. You are maintaing the consistent and that is good.

A separate patch (unrelated with yours) should be provided by somebody else to refactor these classes. I bet it's this code was inherited from the ancient C source code.

Your patch looks fine. Just one note: Shouldn't Extension::get_param_enum_contains be const?