Merge lp:~schwann/ubuntu-ui-toolkit/uitk-missing-search-focus into lp:ubuntu-ui-toolkit

Proposed by Günter Schwann
Status: Merged
Approved by: Francis Ginther
Approved revision: 775
Merged at revision: 778
Proposed branch: lp:~schwann/ubuntu-ui-toolkit/uitk-missing-search-focus
Merge into: lp:ubuntu-ui-toolkit
Diff against target: 25 lines (+2/-2)
2 files modified
modules/Ubuntu/Components/TextArea.qml (+1/-1)
modules/Ubuntu/Components/TextField.qml (+1/-1)
To merge this branch: bzr merge lp:~schwann/ubuntu-ui-toolkit/uitk-missing-search-focus
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Bill Filler (community) Approve
Zoltan Balogh Approve
Review via email: mp+188640@code.launchpad.net

Commit message

Better handle the case of dismissing the OSK and focusing the text again
fixes LP: #1228155

Description of the change

Better handle the case of dismissing the OSK and focusing the text again
fixes LP: #1228155

To post a comment you must log in.
Revision history for this message
Zoltan Balogh (bzoltan) :
review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Francis Ginther (fginther) wrote :

Rebuild of mako test passed: http://10.97.2.10:8080/job/generic-mediumtests-runner-mako/1844/
Re-approving.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

again

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'modules/Ubuntu/Components/TextArea.qml'
2--- modules/Ubuntu/Components/TextArea.qml 2013-07-04 21:36:23 +0000
3+++ modules/Ubuntu/Components/TextArea.qml 2013-10-03 14:19:49 +0000
4@@ -786,7 +786,7 @@
5
6 function activateEditor()
7 {
8- if (!control.activeFocus)
9+ if (!editor.activeFocus)
10 editor.forceActiveFocus();
11 else
12 showInputPanel();
13
14=== modified file 'modules/Ubuntu/Components/TextField.qml'
15--- modules/Ubuntu/Components/TextField.qml 2013-10-01 11:41:48 +0000
16+++ modules/Ubuntu/Components/TextField.qml 2013-10-03 14:19:49 +0000
17@@ -843,7 +843,7 @@
18
19 function activateEditor()
20 {
21- if (!control.activeFocus)
22+ if (!editor.activeFocus)
23 editor.forceActiveFocus();
24 else
25 showInputPanel();

Subscribers

People subscribed via source and target branches

to status/vote changes: