Merge lp:~schwann/ubuntu-keyboard/keyboard-swipe-area into lp:ubuntu-keyboard

Proposed by Günter Schwann
Status: Merged
Approved by: Bill Filler
Approved revision: 76
Merged at revision: 78
Proposed branch: lp:~schwann/ubuntu-keyboard/keyboard-swipe-area
Merge into: lp:ubuntu-keyboard
Diff against target: 53 lines (+17/-2)
3 files modified
qml/Keyboard.qml (+2/-1)
qml/keys/CharKey.qml (+8/-0)
qml/keys/PressArea.qml (+7/-1)
To merge this branch: bzr merge lp:~schwann/ubuntu-keyboard/keyboard-swipe-area
Reviewer Review Type Date Requested Status
Bill Filler (community) Approve
PS Jenkins bot continuous-integration Approve
Review via email: mp+190706@code.launchpad.net

Commit message

Increase the size of the swipe area

Description of the change

Increase the size of the swipe area

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
75. By Günter Schwann

[ Daniel d'Andrada ]
* Various improvements to ubuntu-keyboard-info socket server Make it
  more robust. (LP: #1237870)
[ Thomas Moenicke ]
* more languages.
* new action key icons.
[ Guenter Schwann ]
* Fix for auto caps to work more than once Essentially it's only 25 +
  autoCapsActivated = false;.
[ Ubuntu daily release ]
* Automatic snapshot from revision 75

76. By Günter Schwann

Cancel key presses when a swipe starts

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
Bill Filler (bfiller) wrote :

tested, works

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'qml/Keyboard.qml'
2--- qml/Keyboard.qml 2013-10-11 14:21:24 +0000
3+++ qml/Keyboard.qml 2013-10-14 09:30:29 +0000
4@@ -92,7 +92,8 @@
5 anchors.left: parent.left
6 anchors.right: parent.right
7 anchors.top: parent.top
8- height: (parent.height - canvas.keypadHeight) + wordRibbon.height + units.gu(UI.top_margin)
9+ height: (parent.height - canvas.keypadHeight) + wordRibbon.height +
10+ borderTop.height + units.gu(UI.top_margin) * 3
11
12 drag.target: keyboardSurface
13 drag.axis: Drag.YAxis;
14
15=== modified file 'qml/keys/CharKey.qml'
16--- qml/keys/CharKey.qml 2013-10-08 16:59:12 +0000
17+++ qml/keys/CharKey.qml 2013-10-14 09:30:29 +0000
18@@ -147,6 +147,14 @@
19 }
20 }
21
22+ Connections {
23+ target: swipeArea.drag
24+ onActiveChanged: {
25+ if (swipeArea.drag.active)
26+ keyMouseArea.cancelPress();
27+ }
28+ }
29+
30 Magnifier {
31 anchors.horizontalCenter: buttonImage.horizontalCenter
32 anchors.bottom: buttonImage.top
33
34=== modified file 'qml/keys/PressArea.qml'
35--- qml/keys/PressArea.qml 2013-10-02 13:24:59 +0000
36+++ qml/keys/PressArea.qml 2013-10-14 09:30:29 +0000
37@@ -30,9 +30,15 @@
38 /// Is true while the area is touched, and the finger did not yet lift
39 property bool pressed: false
40
41- /// same as MouseArea pressAndHold()
42+ /// Same as MouseArea pressAndHold()
43 signal pressAndHold()
44
45+ /// Cancels the current pressed state of the mouse are
46+ function cancelPress() {
47+ pressed = false;
48+ holdTimer.stop();
49+ }
50+
51 Timer {
52 id: holdTimer
53 interval: 1000

Subscribers

People subscribed via source and target branches