Merge lp:~schwann/phablet-extras/fix_camera_crash_on_manta into lp:phablet-extras/libhybris

[Günter Schwann]

Do not call releaseRecordingFrame() after capture

Do not call releaseRecordingframe() after capture.
This function is not implemented for exynos2. And is not called by android jni framework.
A test on maguro showed no increase in memory consumption.

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:124
http://jenkins.qa.ubuntu.com/job/phablet-extras-libhybris-ci/5/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-extras-libhybris-quantal-armhf-ci/5
        deb: http://jenkins.qa.ubuntu.com/job/phablet-extras-libhybris-quantal-armhf-ci/5/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-extras-libhybris-quantal-i386-ci/5
    FAILURE: http://jenkins.qa.ubuntu.com/job/phablet-extras-libhybris-raring-armhf-ci/5/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/phablet-extras-libhybris-raring-i386-ci/5/console

Click here to trigger a rebuild:
http://s-jenkins:8080/job/phablet-extras-libhybris-ci/5/rebuild

review: Needs Fixing (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:124
http://jenkins.qa.ubuntu.com/job/phablet-extras-libhybris-ci/9/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-extras-libhybris-raring-armhf-ci/9
        deb: http://jenkins.qa.ubuntu.com/job/phablet-extras-libhybris-raring-armhf-ci/9/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-extras-libhybris-raring-i386-ci/9

Click here to trigger a rebuild:
http://s-jenkins:8080/job/phablet-extras-libhybris-ci/9/rebuild

review: Approve (continuous-integration)

[Sergio Schvezov (sergiusens)]

Wouldn't you need to keep this for the devices not using libcamera2?

review: Needs Information

[Sergio Schvezov (sergiusens)]

This doesn't seem to need a release commit/changelog entry as it's android side only, right?

[lp:~schwann/phablet-extras/fix_camera_crash_on_manta]

125. By Günter Schwann on 2013-05-14

Rever changelog entry

[Günter Schwann (schwann)]

This releaseRecordingFrame() is not even needed in the old libcamera (maybe it was needed before Android 4.2).
As I tested it with maguro, memory doesn't fill up.

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:125
http://jenkins.qa.ubuntu.com/job/phablet-extras-libhybris-ci/12/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-extras-libhybris-raring-armhf-ci/12
        deb: http://jenkins.qa.ubuntu.com/job/phablet-extras-libhybris-raring-armhf-ci/12/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/phablet-extras-libhybris-raring-i386-ci/12

Click here to trigger a rebuild:
http://s-jenkins:8080/job/phablet-extras-libhybris-ci/12/rebuild

review: Approve (continuous-integration)

[Sergio Schvezov (sergiusens)]

It works, no crashes but there is some strange behavior that merits some new bugs.

This is definetly an improvement over crashing though :-)

review: Approve

[Sergio Schvezov (sergiusens)]

HApproved myself since the other reviewers were requested long before I was.

=== modified file 'compat/camera/camera_compatibility_layer.cpp'
--- compat/camera/camera_compatibility_layer.cpp	2013-03-04 23:08:36 +0000
+++ compat/camera/camera_compatibility_layer.cpp	2013-05-14 07:34:26 +0000
@@ -104,8 +104,6 @@
         default:
             break;
         }
-
-        camera->releaseRecordingFrame(data);
     }
 
     void postDataTimestamp(