Merge lp:~schwann/gallery-app/gallery-hopefully-stable-photos-tests into lp:gallery-app

Proposed by Günter Schwann
Status: Merged
Approved by: Günter Schwann
Approved revision: 623
Merged at revision: 623
Proposed branch: lp:~schwann/gallery-app/gallery-hopefully-stable-photos-tests
Merge into: lp:gallery-app
Diff against target: 21 lines (+2/-2)
1 file modified
tests/autopilot/gallery_app/tests/test_photos_view.py (+2/-2)
To merge this branch: bzr merge lp:~schwann/gallery-app/gallery-hopefully-stable-photos-tests
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+155568@code.launchpad.net

Commit message

Makes the photos view tests stable

Description of the change

Hopefully this makes the photos view tests stable on jenkins server.
Greater than anyway makes much more sense then less than.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Autopilot failed in a different test, but the one changed in this MR passed, and the change looks good.

review: Approve
Revision history for this message
Günter Schwann (schwann) wrote :

That was another problem (could not create the thumbnail in time?!?)
Triggering a rebuild.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Günter Schwann (schwann) wrote :

Top approving (as was done already by boiko

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'tests/autopilot/gallery_app/tests/test_photos_view.py'
2--- tests/autopilot/gallery_app/tests/test_photos_view.py 2013-03-26 14:36:06 +0000
3+++ tests/autopilot/gallery_app/tests/test_photos_view.py 2013-03-26 17:56:29 +0000
4@@ -10,7 +10,7 @@
5
6 from __future__ import absolute_import
7
8-from testtools.matchers import Equals, NotEquals
9+from testtools.matchers import Equals, NotEquals, GreaterThan
10 from autopilot.matchers import Eventually
11
12 from gallery_app.tests import GalleryTestCase
13@@ -42,7 +42,7 @@
14
15 #Due to some timing issues sometimes mouse moves to the location a bit earlier
16 #even though the tab item is not fully visible, hence the tab does not activate.
17- self.assertTrue(photos_tab_button.opacity, Eventually(Equals("=<0.2")))
18+ self.assertThat(photos_tab_button.opacity, Eventually(GreaterThan(0.2)))
19
20 photos_tab = self.photos_view.get_photos_tab()
21 self.click_item(photos_tab)

Subscribers

People subscribed via source and target branches