gallery-app

Merge lp:~schwann/gallery-app/gallery-fatser-dtae-compare into lp:gallery-app

  1. gallery-fatser-dtae-compare
  2. Merge into trunk
Proposed by Günter Schwann
Status: Merged
Approved by: Gustavo Pichorim Boiko
Approved revision: 776
Merged at revision: 776
Proposed branch: lp:~schwann/gallery-app/gallery-fatser-dtae-compare
Merge into: lp:gallery-app
Diff against target: 14 lines (+2/-2)
1 file modified
src/media/media-collection.cpp (+2/-2)
To merge this branch: bzr merge lp:~schwann/gallery-app/gallery-fatser-dtae-compare
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Approve
Gustavo Pichorim Boiko (community) Approve
Review via email: mp+175089@code.launchpad.net

Commit message

Minor performance improvement comparing MediaSource dates

To post a comment you must log in.
Revision history for this message
Gustavo Pichorim Boiko (boiko) wrote :

Looks good.

review: Approve
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:776
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/358/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-saucy-amd64-ci/168
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-saucy-armhf-ci/168
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-saucy-armhf-ci/168/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-saucy-i386-ci/168
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1163
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1167
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1167/artifact/work/output/*zip*/output.zip
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/992

Click here to trigger a rebuild:
http://s-jenkins:8080/job/gallery-app-ci/358/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) :
review: Approve (continuous-integration)
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:776
http://jenkins.qa.ubuntu.com/job/gallery-app-ci/359/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-saucy-amd64-ci/169
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-saucy-armhf-ci/169
        deb: http://jenkins.qa.ubuntu.com/job/gallery-app-saucy-armhf-ci/169/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gallery-app-saucy-i386-ci/169
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/1168
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1172
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy/1172/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-saucy/996

Click here to trigger a rebuild:
http://s-jenkins:8080/job/gallery-app-ci/359/rebuild

review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/media/media-collection.cpp'
2--- src/media/media-collection.cpp 2013-07-05 08:12:31 +0000
3+++ src/media/media-collection.cpp 2013-07-16 17:38:29 +0000
4@@ -53,8 +53,8 @@
5 bool MediaCollection::exposureDateTimeAscendingComparator(DataObject* a,
6 DataObject* b)
7 {
8- QDateTime exptime_a = qobject_cast<MediaSource*>(a)->exposureDateTime();
9- QDateTime exptime_b = qobject_cast<MediaSource*>(b)->exposureDateTime();
10+ const QDateTime &exptime_a = qobject_cast<MediaSource*>(a)->exposureDateTime();
11+ const QDateTime &exptime_b = qobject_cast<MediaSource*>(b)->exposureDateTime();
12
13 return (exptime_a == exptime_b) ?
14 (DataCollection::defaultDataObjectComparator(a, b)) :

Subscribers

People subscribed via source and target branches