Merge lp:~schwann/camera-app/camera-disable-unstable-test into lp:camera-app

[Günter Schwann]

Disable test_shoot_button_disable(9 as it is unstable because of a race condition

Disable test_shoot_button_disable(9 as it is unstable because of a race condition
This is a proposal to fix bug #1227373

[lp:~schwann/camera-app/camera-disable-unstable-test]

197. By Günter Schwann on 2013-09-20

Better way to disable the test

[Omer Akram (om26er)]

LGTM

review: Approve

[Olivier Tilloy (osomon)]

18 + @unittest.skip("Disabled this failing test due race condition)

A reference to the bug report would have been useful, for when your future self looks at this test again and wonders which race condition you were talking about.

32 + # enable that test once autopilot can handle it

I don’t think that’s a problem in autopilot. It’s the very nature of this test that makes it unreliable.

[lp:~schwann/camera-app/camera-disable-unstable-test]

198. By Günter Schwann on 2013-09-20

Update comments

[PS Jenkins bot (ps-jenkins)]

PASSED: Continuous integration, rev:196
http://jenkins.qa.ubuntu.com/job/camera-app-ci/106/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-saucy-amd64-ci/59
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-saucy-armhf-ci/58
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-saucy-armhf-ci/58/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-saucy-i386-ci/59
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3739
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1267
    SUCCESS: http://jenkins.qa.ubuntu.com/job/autopilot-testrunner-otto-saucy/85
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3751
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3751/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1269
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1269/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1060
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1072

Click here to trigger a rebuild:
http://s-jenkins:8080/job/camera-app-ci/106/rebuild

review: Approve (continuous-integration)

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:198
http://jenkins.qa.ubuntu.com/job/camera-app-ci/107/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-saucy-amd64-ci/60
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-saucy-armhf-ci/59
        deb: http://jenkins.qa.ubuntu.com/job/camera-app-saucy-armhf-ci/59/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/camera-app-saucy-i386-ci/60
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-saucy/3757/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-touch/1285
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3776
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-i386/3776/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1287
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-saucy-armhf/1287/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-maguro/1077
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-runner-mako/1089

Click here to trigger a rebuild:
http://s-jenkins:8080/job/camera-app-ci/107/rebuild

review: Needs Fixing (continuous-integration)

=== modified file 'tests/autopilot/camera_app/tests/test_capture.py'
--- tests/autopilot/camera_app/tests/test_capture.py	2013-05-28 16:39:40 +0000
+++ tests/autopilot/camera_app/tests/test_capture.py	2013-09-20 12:09:04 +0000
@@ -64,6 +64,9 @@
             time.sleep(1)
         self.assertEquals(one_picture_on_disk, True)
 
+        # check that the camera is able to capture another photo
+        self.assertThat(exposure_button.enabled, Eventually(Equals(True)))
+
     """Tests clicking on the record control and checks if the flash changes
     to torch off mode and the recording time appears"""
     @unittest.skipIf(model() != 'Desktop', 'recording not available on device yet')
@@ -138,15 +141,18 @@
 
     """Test that the shoot button gets disabled for a while then re-enabled
     after shooting"""
+    @unittest.skip("Disabled this test due race condition see bug 1227373")
     def test_shoot_button_disable(self):
         exposure_button = self.main_window.get_exposure_button()
 
         # The focus ring should be invisible in the beginning
-        self.assertEquals(exposure_button.enabled, True)
+        self.assertThat(exposure_button.enabled, Eventually(Equals(True)))
 
         # Now take the picture! (Give it a little time to animate)
         self.pointing_device.move_to_object(exposure_button)
         self.pointing_device.click()
 
+        # autopilot might check this too late, so the exposure_button.enabled
+        # is True again already before the first check
         self.assertThat(exposure_button.enabled, Eventually(Equals(False)))
         self.assertThat(exposure_button.enabled, Eventually(Equals(True)))