Code review comment for lp:~schuster/mysql-proxy/remove_unix_socket

Jan,

thx for review, comments in-line.

On 04.05.10 13:50, Jan Kneschke wrote:
> * remove the commented lines:
>
> /* printf("debug: socket name is %s (addr: %p)\n", pp->sockname, pp); */
> /* g_test_add_func("/core/network_socket_is_local_unix", t_network_socket_is_local_unix);*/

done

> * stay with the existing coding style (no line-break after function declarations)

ack, done.

> * The signal-handler for SIGABRT is installed for _all_ tests of this test-suite. Instead it should be added in the setup and turned back into SIG_DFL in teardown.

done

> * void t_network_socket_is_local_unix() is about the ..._is_local() function. Comments are missing to describe that it also tests for 'socket is removed after successful bind() only'. It would have been better to have seperate test that only tests that.

ack

> g_debug("%s removing socket %s successful", ... is missing a colon after the first %s

this is now gone.

Michael
--
Michael Schuster http://blogs.sun.com/recursion
Recursion, n.: see 'Recursion'