Code review comment for lp:~schuster/mysql-proxy/remove_unix_socket

Revision history for this message
Jan Kneschke (jan-kneschke) wrote :

* remove the commented lines:

  /* printf("debug: socket name is %s (addr: %p)\n", pp->sockname, pp); */
  /* g_test_add_func("/core/network_socket_is_local_unix", t_network_socket_is_local_unix);*/

* stay with the existing coding style (no line-break after function declarations)
* The signal-handler for SIGABRT is installed for _all_ tests of this test-suite. Instead it should be added in the setup and turned back into SIG_DFL in teardown.
* void t_network_socket_is_local_unix() is about the ..._is_local() function. Comments are missing to describe that it also tests for 'socket is removed after successful bind() only'. It would have been better to have seperate test that only tests that.

« Back to merge proposal