Open Font Library

Merge lp:~schrijver/openfontlibrary/font-importer into lp:~bassel/openfontlibrary/font_importer

  1. font-importer
  2. Merge into font_importer
Proposed by Eric Schrijver
Status: Approved
Approved by: Bassel Safadi
Approved revision: 2
Proposed branch: lp:~schrijver/openfontlibrary/font-importer
Merge into: lp:~bassel/openfontlibrary/font_importer
Diff against target: 12 lines (+1/-1)
1 file modified
oflb_extractor.php (+1/-1)
To merge this branch: bzr merge lp:~schrijver/openfontlibrary/font-importer
Reviewer Review Type Date Requested Status
Bassel Safadi Approve
Review via email: mp+47043@code.launchpad.net

Description of the change

This fixes a small bug. The script currently tests if there are ttf’s or ttf’s, which should be ttf’s or otf’s.

Also, this is my attempt at figuring out how Launchpad / bazaar works—it seems quite workable :)

To post a comment you must log in.
Revision history for this message
Bassel Safadi (bassel) :
review: Approve
Reply

Unmerged revisions

2. By Eric Schrijver

Small bug: 'ttf' -> 'otf'

It currently tests if there are ttf’s or ttf’s, which should be ttf’s or
otf’s.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'oflb_extractor.php'
2--- oflb_extractor.php 2010-10-18 21:15:04 +0000
3+++ oflb_extractor.php 2011-01-21 14:41:59 +0000
4@@ -45,7 +45,7 @@
5 if (!$extractor->fontlog){
6 echo "no fontlog found";
7 }
8- if (empty($extractor->foundFiles['ttf']) && empty($extractor->foundFiles['ttf'])){
9+ if (empty($extractor->foundFiles['ttf']) && empty($extractor->foundFiles['otf'])){
10 echo "No font files found\n";
11 }
12 if (empty($extractor->foundFiles['sfd']) && empty($extractor->foundFiles['vfb'])){

Subscribers

People subscribed via source and target branches