Code review comment for lp:~schampagne/openerp-manufacturing/mrp_bom_product_details

Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

As this is for version 7.0, it would be better to:

Inherit from orm.Model instead of osv.osv, because osv.osv is deprecated
    from openerp.osv import fields, orm
    from import _

    class mrp_bom(orm.Model):

And you no longer need to instantiate your model at line 107

The lines 103, 104 are very long...

So it would be great if you can change that.

Expect that, that looks good to me

review: Approve (no test, review)

« Back to merge proposal