Merge lp:~sbte/indicator-application/fix-memory-leak into lp:indicator-application/0.5

Proposed by Sven Baars
Status: Merged
Approved by: Ted Gould
Approved revision: 220
Merged at revision: 220
Proposed branch: lp:~sbte/indicator-application/fix-memory-leak
Merge into: lp:indicator-application/0.5
Diff against target: 16 lines (+1/-1)
1 file modified
src/application-service-appstore.c (+1/-1)
To merge this branch: bzr merge lp:~sbte/indicator-application/fix-memory-leak
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Review via email:

Description of the change

Free the result of g_dbus_proxy_call_finish after use

I'm not sure if this really fixes , but I think this was a real leak, so I shouldn't do any harm.

To post a comment you must log in.
Revision history for this message
Hernando Torque (htorque) wrote :

Unfortunately not fixing the big leak.

Revision history for this message
Ted Gould (ted) wrote :

Looks good. Also, for Hernando, did you try 0.4.90? I fixed a few
leaks in that one as well.

  status approved
  review approve

review: Approve
Revision history for this message
Hernando Torque (htorque) wrote :

Yes, see bug 930291. I now also tried it again with all the (non-unity-2d) stuff from the Unity staging PPA compiled from trunk + the three not yet merged patches from sbte → no luck. It's also not application dependent (running all combinations of: nm-applet, cpufreq, sensors, multiload).

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/application-service-appstore.c'
2--- src/application-service-appstore.c 2012-02-08 16:59:30 +0000
3+++ src/application-service-appstore.c 2012-02-11 11:06:17 +0000
4@@ -1466,6 +1466,7 @@
5 if (error == NULL) {
6 g_variant_get(result, "(b)", &approved);
7 g_debug("Approver responded: %s", approved ? "approve" : "rejected");
8+ g_variant_unref(result);
9 }
10 else {
11 g_debug("Approver responded error: %s", error->message);
12@@ -1654,4 +1655,3 @@
14 return;
15 }


People subscribed via source and target branches