lp:~sbte/bamf/fix-memory-leak

Branch merges

Propose for merging

No branches dependent on this one.

Merged into lp:bamf/0.4 at revision 444

Marco Trevisan (Treviño): Approve on 2012-02-15

Diff: 27 lines (+3/-1)

1 file modified

src/bamf-indicator-source.c (+3/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

443. By Sven Baars on 2012-02-11

Make sure the result of g_dbus_proxy_call_sync is unreffed

442. By Jason Smith on 2012-02-10

Fix approved in IRC by desrt. Fixes: . Approved by .

441. By Jason Smith on 2012-02-10

Make sure we actually get UTF8 strings when needed. Fixes: . Approved by Ted Gould.

440. By Jason Smith on 2012-02-10

Implements updates to the dbus menu spec (new atoms mostly)

Merge does not contain tests. Tests will be covered in User Acceptance testing in Unity later when the required dependencies for the tests are available.. Fixes: . Approved by Ted Gould.

439. By Marco Trevisan (Treviño) on 2012-02-09

Some bool are returned on non-gboolean functions, fixed them plus a gerror memory leak. Fixes: . Approved by Michal Hruby.

438. By Sven Baars on 2012-02-09

This should fix

==1933== 96 bytes in 8 blocks are definitely lost in loss record 8,181 of 10,585
==1933== at 0x4C296CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==1933== by 0x6710918: g_malloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0)
==1933== by 0x6702A4C: ??? (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0)
==1933== by 0x6703DDF: g_key_file_get_string (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0)
==1933== by 0x2366A677: bamf_application_new_favorite (in /usr/lib/x86_64-linux-gnu/libbamf3.so.0.0.0)
==1933== by 0x2366F34F: bamf_factory_app_for_file (in /usr/lib/x86_64-linux-gnu/libbamf3.so.0.0.0)
==1933== by 0x2366C023: bamf_matcher_get_application_for_desktop_file (in /usr/lib/x86_64-linux-gnu/libbamf3.so.0.0.0)
==1933== by 0x22D83554: unity::launcher::Controller::Impl::CreateFavorite(char const*) (in /usr/lib/compiz/libunityshell.so)
==1933== by 0x22D8623B: unity::launcher::Controller::Impl::SetupBamf() (in /usr/lib/compiz/libunityshell.so)
==1933== by 0x22D865A8: ??? (in /usr/lib/compiz/libunityshell.so)
==1933== by 0x670B76A: ??? (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0)
==1933== by 0x670AB29: g_main_context_dispatch (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0). Fixes: . Approved by Michal Hruby.

437. By Sven Baars on 2012-02-08

This should fix

==1994== 49 (16 direct, 33 indirect) bytes in 1 blocks are definitely lost in loss record 11,086 of 25,065
==1994== at 0x4C296CD: malloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==1994== by 0x4C29857: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==1994== by 0x670D9D6: g_realloc (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0)
==1994== by 0x66DCB58: ??? (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0)
==1994== by 0x66DCCD3: g_array_sized_new (in /lib/x86_64-linux-gnu/libglib-2.0.so.0.3116.0)
==1994== by 0x10EC9D96: ??? (in /usr/lib/x86_64-linux-gnu/libdbus-glib-1.so.2.2.2)
==1994== by 0x10ECAAD4: ??? (in /usr/lib/x86_64-linux-gnu/libdbus-glib-1.so.2.2.2)
==1994== by 0x10EC437C: ??? (in /usr/lib/x86_64-linux-gnu/libdbus-glib-1.so.2.2.2)
==1994== by 0x10EC769A: dbus_g_proxy_call (in /usr/lib/x86_64-linux-gnu/libdbus-glib-1.so.2.2.2)
==1994== by 0x1B0DB81E: bamf_view_get_children (in /usr/lib/x86_64-linux-gnu/libbamf3.so.0.0.0)
==1994== by 0x19EE94B3: unity::launcher::BamfLauncherIcon::EnsureWindowState() (in /usr/lib/compiz/libunityshell.so)
==1994== by 0x19EE9B87: unity::launcher::BamfLauncherIcon::BamfLauncherIcon(_BamfApplication*) (in /usr/lib/compiz/libunityshell.so). Fixes: . Approved by Mikkel Kamstrup Erlandsen.

436. By Marco Trevisan (Treviño) on 2012-02-07

Makes bamf not double add items if the user calls get_children before a child-added signal arrives.. Fixes: https://bugs.launchpad.net/bugs/928014. Approved by Tim Penhey.

435. By Didier Roche-Tolomelli on 2012-02-03

releasing 0.2.108

434. By Marco Trevisan (Treviño) on 2012-01-28

Libreoffice desktop files have changed the exec parameter in last upgrade, we need to match them correctly.

Code updated to support both the old and the new lo .desktop files.. Fixes: https://bugs.launchpad.net/bugs/919892. Approved by Jason Smith.