Merge lp:~sbi/account-invoicing/6.1-account_invoice_total into lp:~account-core-editors/account-invoicing/6.1

[Stéphane Bidoul (Acsone)]

Until OpenERP 6.0.3 when creating a supplier invoice one first had to enter the grand total, this had to match with the computed total before the invoice could be verified.

In OpenERP 6.1 this feature has silently been removed.

This merge proposal provides the account_invoice_total module which brings back the field and the extra verification check.

Discussion : https://bugs.launchpad.net/openobject-addons/+bug/998008
Code Revision : http://bazaar.launchpad.net/~openerp/openobject-addons/trunk/revision/6254

This module was originally created at https://github.com/arnebrasseur/openerp-account_invoice_total by arne brasseur and simplified by myself.

[Joël Grand-Guillaume @ camptocamp (jgrandguillaume-c2c)]

Ok for me. Code looks ok, good place to be committed IMHO.

review: Approve

[lp:~sbi/account-invoicing/6.1-account_invoice_total]

13. By Stéphane Bidoul (Acsone) on 2012-11-21

[IMP] account_invoice_total has 2 authors

[Stéphane Bidoul (Acsone) (sbi)]

What's the next step for merging this one?

[Stefan Rijnhart (Opener) (stefan-opener)]

Hi,

merged with an additional comment about this option in 7.0

Cheers,
Stefan.

[Niels Huylebroeck (red15)]

What is the purpose of the README.md file ? Is this some form of markup ? If so we should as community gather around a central format which everyone can agree upon so we can make such files a requirement when committing new modules.

Also a bit strange why required="2" on the check_total field ? Why is value 2 not 1 or True, I prefer the latter personally.

[Stéphane Bidoul (Acsone) (sbi)]

md is for markdown. That said, README.md is redundant to __openerp__.py and could be removed.

The required="2" comes from the 6.0 account_invoice_view.xml. I have no idea if it means something different than 1 or True.

-sbi

=== added directory 'account_invoice_total'
=== added file 'account_invoice_total/README.md'
--- account_invoice_total/README.md	1970-01-01 00:00:00 +0000
+++ account_invoice_total/README.md	2012-11-21 10:31:19 +0000
@@ -0,0 +1,21 @@
+# Account_invoice_total for OpenERP 6.1
+
+Until OpenERP 6.0.3 when creating a supplier invoice one first had to enter the grand total, this had to match with the computed total before the invoice could be verified.
+
+In OpenERP 6.1 this feature has silently been removed. This module brings back the field and the extra verification check.
+
+## Links
+
+Discussion : https://bugs.launchpad.net/openobject-addons/+bug/998008
+Code Revision : http://bazaar.launchpad.net/~openerp/openobject-addons/trunk/revision/6254
+
+## License
+
+Copyright (c) 2012 Ren Dao Solutions bvba
+Copyright (c) 2012 ACSONE SA/NV
+
+This module is free software: you can redistribute it and/or modify it under the terms of the GNU Affero General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version.
+
+This program is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU Affero General Public License for more details.
+
+For a full text of the license see <http://www.gnu.org/licenses/agpl-3.0.html>

=== added file 'account_invoice_total/__init__.py'
--- account_invoice_total/__init__.py	1970-01-01 00:00:00 +0000
+++ account_invoice_total/__init__.py	2012-11-21 10:31:19 +0000
@@ -0,0 +1,25 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    account_invoice_total module for OpenERP
+#    Copyright (C) 2012 Ren Dao Solutions (<http://rendaosolutions.com>).
+#    Copyright (C) 2012 Acsone (<http://acsone.eu>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import account_invoice_total
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'account_invoice_total/__openerp__.py'
--- account_invoice_total/__openerp__.py	1970-01-01 00:00:00 +0000
+++ account_invoice_total/__openerp__.py	2012-11-21 10:31:19 +0000
@@ -0,0 +1,43 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    account_invoice_total module for OpenERP
+#    Copyright (C) 2012 Ren Dao Solutions (<http://rendaosolutions.com>).
+#    Copyright (C) 2012 Acsone (<http://acsone.eu>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+{   'name': 'Total Field on Supplier Invoice',
+    'version': '0.1',
+    'category': 'Accounting',
+    'description': """
+Since OpenERP 6.1 the check_total field in the supplier invoice form, and the corresponding
+check, has been removed. This module brings back the functionality from 6.0 and before.
+
+See discussion : https://bugs.launchpad.net/openobject-addons/+bug/998008
+See revision : http://bazaar.launchpad.net/~openerp/openobject-addons/trunk/revision/6254
+    """,
+    'author': 'Ren Dao Solutions bvba, ACSONE SA/NV',
+    'depends': [
+        'account',
+    ],
+    'init_xml': [
+        'account_invoice_total_view.xml'
+    ],
+    'update_xml': [],
+    'demo_xml': [],
+    'installable': True,
+}
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'account_invoice_total/account_invoice_total.py'
--- account_invoice_total/account_invoice_total.py	1970-01-01 00:00:00 +0000
+++ account_invoice_total/account_invoice_total.py	2012-11-21 10:31:19 +0000
@@ -0,0 +1,38 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    account_invoice_total module for OpenERP
+#    Copyright (C) 2012 Ren Dao Solutions (<http://rendaosolutions.com>).
+#    Copyright (C) 2012 Acsone (<http://acsone.eu>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from osv import fields, osv
+from tools.translate import _
+
+class account_invoice_total(osv.osv):
+    _inherit = 'account.invoice'
+  
+    def action_move_create(self, cr, uid, ids, context=None):
+        res = super(account_invoice_total, self).action_move_create(cr, uid, ids, context=context)
+        for inv in self.browse(cr, uid, ids, context=context):
+            if inv.type in ('in_invoice', 'in_refund') and abs(inv.check_total - inv.amount_total) >= (inv.currency_id.rounding/2.0):
+                raise osv.except_osv(_('Bad total !'), _('Please verify the price of the invoice !\nThe real total does not match the computed total.'))
+        return res
+
+account_invoice_total()
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'account_invoice_total/account_invoice_total_view.xml'
--- account_invoice_total/account_invoice_total_view.xml	1970-01-01 00:00:00 +0000
+++ account_invoice_total/account_invoice_total_view.xml	2012-11-21 10:31:19 +0000
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+	<data>
+		<record id="account_invoice_total_supplier_form" model="ir.ui.view">
+			<field name="name">account.invoice.supplier.form</field>
+			<field name="model">account.invoice</field>
+			<field name="type">form</field>
+			<field name="inherit_id" ref="account.invoice_supplier_form"/>
+			<field name="arch" type="xml">
+				<field name="date_due" position="after">
+					<field name="check_total" required="2"/>
+				</field>
+			</field>
+		</record>
+	</data>
+</openerp>