Account - Financial Report

Code review comment for lp:~sbi/account-financial-report/account-financial-report-bug1172779

  1. account-financial-report-bug1172779
  2. Merge into trunk
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

Hi,

Thanks for your fix!

It happens that an alternative fix has landed here: https://code.launchpad.net/~account-report-core-editor/account-financial-report/fix-gl-opening-period-show-balance

The 2 approaches are different:
 - You display all the opening entries as individual lines (as it was already done before)
 - The other branch always display sums of opening entries

Upon reflection, we prefer to display the sum, so the numbers are similar to what we see in the trial balance (it does not change too much for accounts with 1 entry, but for customer/supplier accounts, we need to sum the opening entries to correlate with the TB).

Do you bother if the other branch's fix is preferred?

review: Needs Information

« Back to merge proposal