Merge ~sbeattie/qa-regression-testing:ci-test-git into qa-regression-testing:master

Proposed by Steve Beattie
Status: Merged
Merged at revision: d9aa84f661745b426c9b55a277371746256a34fe
Proposed branch: ~sbeattie/qa-regression-testing:ci-test-git
Merge into: qa-regression-testing:master
Diff against target: 39 lines (+15/-1)
2 files modified
.launchpad.yaml (+14/-0)
scripts/test-git.py (+1/-1)
Reviewer Review Type Date Requested Status
Alex Murray Approve
Review via email: mp+442715@code.launchpad.net

Description of the change

Convert the test-git.py script to python3 (tested to function fine on trusty and xenial) and add it to the lpci tests.

To post a comment you must log in.
Revision history for this message
Steve Beattie (sbeattie) wrote :

I should note that the changes to the .launchpad.yaml were mostly a case of copy-waste. One thing I did trip over is that the order of the jobs in the pipeline section must match the order listed in the jobs section, or lpi becomes very confused.

Revision history for this message
Alex Murray (alexmurray) wrote :

LGTM! - thanks for this @sbeattie - moar CI!!!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/.launchpad.yaml b/.launchpad.yaml
2index 74015b8..b45d9ff 100644
3--- a/.launchpad.yaml
4+++ b/.launchpad.yaml
5@@ -4,6 +4,7 @@ pipeline:
6 - gcc-security
7 - gnupg
8 - sudo
9+ - git
10
11 jobs:
12 imagemagick:
13@@ -57,3 +58,16 @@ jobs:
14 - sudo
15 run: |
16 ./lpcraft-runner gnupg
17+
18+ git:
19+ matrix:
20+ - series: jammy
21+ architectures: amd64
22+ - series: focal
23+ architectures: amd64
24+ - series: bionic
25+ architectures: amd64
26+ packages:
27+ - sudo
28+ run: |
29+ ./lpcraft-runner git
30diff --git a/scripts/test-git.py b/scripts/test-git.py
31index 45dffc1..fa851d8 100755
32--- a/scripts/test-git.py
33+++ b/scripts/test-git.py
34@@ -1,4 +1,4 @@
35-#!/usr/bin/python2
36+#!/usr/bin/python3
37 #
38 # test-git-core.py quality assurance test script for PKG
39 # Copyright (C) 2008-2015 Canonical Ltd.

Subscribers

People subscribed via source and target branches