Merge lp:~sbaldassin/ubuntu-system-tests/fix_launch_app_from_scope into lp:ubuntu-system-tests

Proposed by Santiago Baldassin
Status: Work in progress
Proposed branch: lp:~sbaldassin/ubuntu-system-tests/fix_launch_app_from_scope
Merge into: lp:ubuntu-system-tests
Diff against target: 14 lines (+1/-3)
1 file modified
ubuntu_system_tests/helpers/scopes/base.py (+1/-3)
To merge this branch: bzr merge lp:~sbaldassin/ubuntu-system-tests/fix_launch_app_from_scope
Reviewer Review Type Date Requested Status
platform-qa-bot continuous-integration Needs Fixing
Heber Parrucci (community) Needs Fixing
prod-platform-qa continuous-integration Pending
Review via email: mp+312196@code.launchpad.net

Commit message

Moving from click to click_object when launching apps from scope

Description of the change

This merge proposal makes use of the pointer click_object method which calculates the clicking point for us

@run_tests: ubuntu_system_tests.tests.test_calculator

To post a comment you must log in.
Revision history for this message
Heber Parrucci (heber013) wrote :

This change also affects open_preview, add this tests to execute:

ubuntu_system_tests.tests.test_uninstall_application.UninstallApplicationTestCase.test_uninstall_application

also affects go_to_store function, so add:
ubuntu_system_tests.tests.test_app_store.AppStoreTestCase.test_install_free_app

review: Needs Fixing
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Approve (continuous-integration)
489. By Santiago Baldassin

addressing commnets from the reviews

Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Needs Fixing (continuous-integration)

Unmerged revisions

489. By Santiago Baldassin

addressing commnets from the reviews

488. By Santiago Baldassin

using click_object instead of click

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'ubuntu_system_tests/helpers/scopes/base.py'
2--- ubuntu_system_tests/helpers/scopes/base.py 2016-11-25 15:00:36 +0000
3+++ ubuntu_system_tests/helpers/scopes/base.py 2016-11-30 20:57:57 +0000
4@@ -151,9 +151,7 @@
5 list_view = self.select_single('ListViewWithPageHeader',
6 objectName='categoryListView')
7 list_view.swipe_child_into_view(icon)
8-
9- self._move_to_visible_click_point(list_view, icon)
10- self.pointing_device.click(press_duration=press_duration)
11+ self.pointing_device.click_object(icon, press_duration=press_duration)
12
13 def _move_to_visible_click_point(self, icon_list, icon):
14 """ Move to a visible point to click due to the icon could be partially

Subscribers

People subscribed via source and target branches