Merge ~sbaldassin/ubuntu-app-platform:testability into ubuntu-app-platform:master

Proposed by Santiago Baldassin
Status: Needs review
Proposed branch: ~sbaldassin/ubuntu-app-platform:testability
Merge into: ubuntu-app-platform:master
Diff against target: 12 lines (+1/-0)
1 file modified
snapcraft.yaml (+1/-0)
Reviewer Review Type Date Requested Status
Timo Jyrinki Needs Fixing
Review via email: mp+314690@code.launchpad.net

Commit message

Adding the testability libraries to the platform snap

Description of the change

This mp adds the testability library to the ubuntu-app-platform snap so that snaps connected to the platform snap can be introspected by autopilot

To post a comment you must log in.
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

libautopilot-qt-autopilot depends on libautopilot-qt that depends on autopilot-qt4 which depends on all of Qt 4. This would add over 50% more size to ubuntu-app-platform for no practical use which we don't want.

libautopilot-qt-autopilot also directly depends on libqt4-declarative, libqtcore4 and libqtgui4.

All direct or indirect dependencies on Qt 4 need be removed from libautopilot-qt-autopilot before this can go in.

review: Needs Fixing
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

(small correction: it seems actually 50% is exaggeration, I counted wrong, but still it's tens of megabytes)

Revision history for this message
Santiago Baldassin (sbaldassin) wrote :

> (small correction: it seems actually 50% is exaggeration, I counted wrong, but
> still it's tens of megabytes)

Thanks for the feedback Timo. I'll get rid of Qt4 deps

Unmerged commits

6152ecb... by Santiago Baldassin

Adding libautopilot-qt-autopilot to the app platform

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/snapcraft.yaml b/snapcraft.yaml
2index 8a890c6..bb19554 100644
3--- a/snapcraft.yaml
4+++ b/snapcraft.yaml
5@@ -19,6 +19,7 @@ parts:
6 ubuntu-app-platform:
7 plugin: nil
8 stage-packages:
9+ - libautopilot-qt-autopilot
10 - fontconfig
11 - libc6
12 - libcups2

Subscribers

People subscribed via source and target branches