Merge lp:~sbaldassin/snappy-ecosystem-tests/fix_install_deps into lp:snappy-ecosystem-tests

Proposed by Santiago Baldassin
Status: Merged
Approved by: Omer Akram
Approved revision: 26
Merged at revision: 27
Proposed branch: lp:~sbaldassin/snappy-ecosystem-tests/fix_install_deps
Merge into: lp:snappy-ecosystem-tests
Diff against target: 22 lines (+3/-2)
1 file modified
snappy_ecosystem_tests/environment/managers.py (+3/-2)
To merge this branch: bzr merge lp:~sbaldassin/snappy-ecosystem-tests/fix_install_deps
Reviewer Review Type Date Requested Status
Omer Akram (community) Approve
platform-qa-bot continuous-integration Approve
Review via email: mp+318910@code.launchpad.net

Commit message

Fix dependencies installation

Description of the change

This mp fix the dependencies installation process in the containers

To post a comment you must log in.
Revision history for this message
platform-qa-bot (platform-qa-bot) wrote :
review: Approve (continuous-integration)
Revision history for this message
Omer Akram (om26er) wrote :

ok, looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'snappy_ecosystem_tests/environment/managers.py'
2--- snappy_ecosystem_tests/environment/managers.py 2017-03-03 10:19:23 +0000
3+++ snappy_ecosystem_tests/environment/managers.py 2017-03-03 13:45:50 +0000
4@@ -76,7 +76,8 @@
5 """Install a packages"""
6 container = self.client.containers.get(container_name)
7 container.execute(shlex.split('apt-get update'))
8- install_command = 'apt-get install {} -y'.format(packages)
9+ install_command = 'apt-get install {} -y'.format(
10+ ' '.join(packages))
11 if channel:
12 install_command += ' -t {}'.format(channel)
13 container.execute(shlex.split(install_command))
14@@ -125,7 +126,7 @@
15 self.enable_ssh(container_name)
16 self.install(
17 container_name,
18- packages=PROFILES[profile][container_type]["package_name"],
19+ packages=[PROFILES[profile][container_type]["package_name"]],
20 channel=PROFILES[profile][container_type]["channel"])
21 self.install_dependencies(container_name, container_type)
22 self.configure(container_name, container_type, profile)

Subscribers

People subscribed via source and target branches

to all changes: