Merge lp:~sbaldassin/snappy-ecosystem-tests/ecosystem_unit_tests into lp:snappy-ecosystem-tests

[Santiago Baldassin]

Adding unit tests

Adding a unit tests mechanism

[platform-qa-bot (platform-qa-bot)]

FAILED: Continuous integration, rev:13
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/13/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1585/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/13/rebuild

review: Needs Fixing (continuous-integration)

[platform-qa-bot (platform-qa-bot)]

FAILED: Continuous integration, rev:13
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/14/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1586/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/14/rebuild

review: Needs Fixing (continuous-integration)

[platform-qa-bot (platform-qa-bot)]

FAILED: Continuous integration, rev:14
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/15/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1587/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/15/rebuild

review: Needs Fixing (continuous-integration)

[platform-qa-bot (platform-qa-bot)]

PASSED: Continuous integration, rev:14
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/16/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1588/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/16/rebuild

review: Approve (continuous-integration)

[platform-qa-bot (platform-qa-bot)]

FAILED: Continuous integration, rev:15
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/17/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1589/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/17/rebuild

review: Needs Fixing (continuous-integration)

[platform-qa-bot (platform-qa-bot)]

FAILED: Continuous integration, rev:16
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/18/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1590/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/18/rebuild

review: Needs Fixing (continuous-integration)

[platform-qa-bot (platform-qa-bot)]

PASSED: Continuous integration, rev:17
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/19/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-update-mp/1591/console

Click here to trigger a rebuild:
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-ci/19/rebuild

review: Approve (continuous-integration)

[Heber Parrucci (heber013)]

Looks good to me. Let's land it to adapt other branches to the new check mechanism

review: Approve

[platform-qa-bot (platform-qa-bot)]

FAILED: Autolanding.
Unapproved changes made after approval.
https://platform-qa-jenkins.ubuntu.com/job/snappy-ecosystem-tests-autoland/3/
Executed test runs:
    None: https://platform-qa-jenkins.ubuntu.com/job/generic-land-mp/2665/console

review: Needs Fixing (continuous-integration)

[platform-qa-bot (platform-qa-bot)]

review: Approve (continuous-integration)

=== modified file 'pylint.cfg'
--- pylint.cfg	2017-02-07 17:41:23 +0000
+++ pylint.cfg	2017-02-10 20:22:49 +0000
@@ -82,7 +82,7 @@
 files-output=no
 
 # Tells whether to display a full report or only the messages
-reports=yes
+reports=no
 
 # Python expression which should return a note less than 10 (10 is the highest
 # note). You have access to the variables errors warning, statement which

=== added file 'requirements-unit-tests.txt'
--- requirements-unit-tests.txt	1970-01-01 00:00:00 +0000
+++ requirements-unit-tests.txt	2017-02-10 20:22:49 +0000
@@ -0,0 +1,1 @@
+unittest2

=== modified file 'requirements.txt'
--- requirements.txt	2017-02-07 17:41:23 +0000
+++ requirements.txt	2017-02-10 20:22:49 +0000
@@ -1,2 +1,3 @@
 pexpect
 selenium
+unittest2

=== renamed file 'run_pylint' => 'run_checks'
--- run_pylint	2017-02-07 19:24:53 +0000
+++ run_checks	2017-02-10 20:22:49 +0000
@@ -1,22 +1,69 @@
 #!/bin/bash
-
-virtualenv -p python3 ve_pylint
-. ve_pylint/bin/activate
-
-proxy=$1
-if [ "$proxy" ]; then
-    echo "Using proxy: $proxy to install dependencies"
-    pip install --proxy $proxy pylint
-    pip install --proxy $proxy -r requirements.txt
-else
-    pip install pylint
-    pip install -r requirements.txt
-fi
-
-ve_pylint/bin/python3 -m pylint snappy_ecosystem_tests --reports=y --rcfile=pylint.cfg > pylint-results.txt
-
-result=$?
-
-deactivate
-
-if [ $result != 0 ] && [ $result != 4 ]; then exit 1; fi
+RED='\033[0;31m'
+GREEN='\033[0;32m'
+
+case "${1:-all}" in
+    --all)
+        STATIC=1
+        UNIT=1
+        ;;
+    --static)
+        STATIC=1
+        ;;
+    --unit)
+        UNIT=1
+        ;;
+    *)
+        echo "Wrong flag ${1}. To run a single suite use --static, --unit"
+        exit 1
+esac
+
+if [ "$STATIC" = 1 ]; then 
+    virtualenv -p python3 ve_pylint
+    . ve_pylint/bin/activate
+
+    proxy=$2
+    if [ "$proxy" ]; then
+        echo "Using proxy: $proxy to install dependencies"
+        pip install --proxy $proxy pylint
+        pip install --proxy $proxy -r requirements.txt
+    else
+        pip install pylint
+        pip install -r requirements.txt
+    fi
+
+    ve_pylint/bin/python3 -m pylint snappy_ecosystem_tests --reports=n --rcfile=pylint.cfg > pylint-results.txt
+
+    result=$?
+    if [ $result != 0 ] && [ $result != 4 ]; then 
+        echo -e -n "${RED}Pylint errors. Check pylint output for more information\n"
+        exit 1; 
+    else
+        echo -e -n "${GREEN}Congratulations!!! Static check PASSED\n"
+    fi
+    deactivate
+fi
+
+if [ "$UNIT" = 1 ]; then
+    virtualenv -p python3 ve_unit_tests
+    . ve_unit_tests/bin/activate
+
+    if [ "$proxy" ]; then
+        echo "Using proxy: $proxy to install dependencies"
+        pip install --proxy $proxy -r requirements-unit-tests.txt
+    else
+        pip install -r requirements-unit-tests.txt
+    fi
+
+    ve_unit_tests/bin/python3 -m unittest discover snappy_ecosystem_tests.unittests 
+
+    result=$?
+    deactivate
+
+    if [ $result != 0 ]; then
+        echo -e -n "${RED}Unit tests failed.\n"
+        exit 1;
+    else
+        echo -e -n "${GREEN}Congratulations!!! Unit tests PASSED\n"
+    fi
+fi

=== added directory 'snappy_ecosystem_tests/unittests'
=== added file 'snappy_ecosystem_tests/unittests/__init__.py'
=== added file 'snappy_ecosystem_tests/unittests/test_snapcraft.py'
--- snappy_ecosystem_tests/unittests/test_snapcraft.py	1970-01-01 00:00:00 +0000
+++ snappy_ecosystem_tests/unittests/test_snapcraft.py	2017-02-10 20:22:49 +0000
@@ -0,0 +1,29 @@
+# -*- Mode: Python; coding: utf-8; indent-tabs-mode: nil; tab-width: 4 -*-
+
+#
+# Snappy Ecosystem Tests
+# Copyright (C) 2017 Canonical
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+
+"""Unit tests cases for snapcraft"""
+
+from unittest2 import TestCase
+
+class SnapcraftTestCase(TestCase):
+
+    def test_snapcraft_dummy_test(self):
+        """Dummy test case"""
+        self.assertTrue(True)