Merge ~sbaldassin/bileto:bileto_ust into bileto:master

[Santiago Baldassin]

Trigger ubuntu system tests from bileto

Trigger ubuntu system tests from bileto

[Robert Bruce Park (robru)]

Good progress here, see comments inline, thanks!

review: Needs Fixing

[Santiago Baldassin (sbaldassin)]

Thanks for the feedback Robert. I've added the unit tests and also replied to you inline

[Robert Bruce Park (robru)]

For now just write a file please. You can just write the status to /tmp/bileto/REQUESTID.ust, then you can check that file and see if it's started yet or not.

I really can't accept this branch with the schema changes, I need to do up a big schema migration with unrelated changes and I don't want to block on that.

[Robert Bruce Park (robru)]

Some comments on the tests too

review: Needs Fixing

[Robert Bruce Park (robru)]

Bileto is self-hosting so I created a ticket here:

https://bileto.ubuntu.com/#/ticket/2029

There's no bileto package in ubuntu so it's not necessary to publish the ticket, the ticket can just be finalized after tests pass and I try it out in staging.

[Robert Bruce Park (robru)]

argh, tests of course failed because the qakit dependency is missing.

[Robert Bruce Park (robru)]

Ok, apologies again, our self-hosting ability was somewhat bitrotted, it's been a while since I had an MP from another developer ;-)

I've resolved the test failures that were unrelated to your branch, please rebase your work on the latest master.

[Santiago Baldassin (sbaldassin)]

Thanks Robert. I'll try to come up with something to avoid the changes in models

[Santiago Baldassin (sbaldassin)]

Hi Robert, I've addressed all your concerns last week. Would you please take a new look? thanks

[Robert Bruce Park (robru)]

Hi Santiago, sorry for the delay, Monday was a holiday and i was sick a couple days last week.

One question, once this starts triggering tests, where is the Jenkins located for checking results?

Also more comments inline.

review: Needs Fixing

[Robert Bruce Park (robru)]

Also these two test failure need to be resolved:

https://launchpadlibrarian.net/289230891/buildlog_ubuntu-xenial-amd64.bileto_1.0+16.04.20161011-0ubuntu1_BUILDING.txt.gz

Please make sure you are running the tests locally to confirm everything is working.

[Robert Bruce Park (robru)]

I've spoken with my manager (Steve) and he's requested that I just take over this from here, so don't worry about resolving the issues I pointed out in my previous reviews!

Unmerged commits

c89ca6c... by Santiago Baldassin on 2016-09-28

Triger ubuntu system tests

diff --git a/bileto/models.py b/bileto/models.py
index c4c133a..b6df014 100644
--- a/bileto/models.py
+++ b/bileto/models.py
@@ -53,6 +53,10 @@ BRITNEY_SIGNOFF = """Automated Signoff
 Indicates if britney has approved the ticket based on autopkgtests & other \
 factors. Check the excuses page for details."""
 
+UST_BUILD_URL = """Ubuntu System Tests Build url
+
+Indicates the url of the build"""
+
 CREATOR = """Request Creator
 
 Launchpad nickname of the person who created this request."""
diff --git a/britney/iterate.py b/britney/iterate.py
index 7dede19..8470635 100755
--- a/britney/iterate.py
+++ b/britney/iterate.py
@@ -13,14 +13,15 @@ from json import dumps
 from time import strftime
 from pprint import pformat
 from datetime import datetime
-from contextlib import suppress
 from subprocess import Popen, PIPE
 from fcntl import LOCK_EX, LOCK_NB, flock
 
 from os import environ, unlink, symlink
 from os.path import abspath, dirname, exists
 
+import requests
 from requests import get, post
+from contextlib import suppress
 
 HOME = dirname(abspath(__file__))
 ROOT = dirname(HOME)
@@ -30,6 +31,9 @@ sys.path.append(ROOT)
 # pylint: disable=wrong-import-position
 from bileto.settings import Config  # noqa
 
+with suppress(ImportError):
+    from qakit.ust.worker import Worker, UstResult
+
 
 PUBLIC = '/static/britney/'
 OUTPUT = '/tmp/britney_output/'
@@ -191,6 +195,23 @@ def parallelize_fetching(all_series, runs):
         update_request(ticket)
 
 
+def compute_ust_signoff(reqs):
+    """Notify the ticket status in ubuntu system tests.
+    Once a silo is assigned to the ticket, ust is triggered only if
+    the lander has approved the ticket. After triggering the tests,
+    the worker is asked for results
+    :return UstResult which has two attributes: status and build url
+    which are both use in the UI"""
+    for request in reqs:
+        if request['siloname']:
+            ust_worker = Worker()
+            if request['lander_signoff'] == 'Approved':
+                try:
+                    ust_worker.run_ust(request['siloname'])
+                except Exception:
+                    pass
+
+
 def print_proc(proc):
     """Print the output from a subprocess."""
     sys.stdout.buffer.write(BNEWLINE.join(
@@ -207,6 +228,7 @@ def main():
         sys.stderr = sys.stdout = open(LOG_NAME, 'x')
         reqs = get_requests()
         parallelize_fetching(*build_siloname_dict(reqs))
+        compute_ust_signoff(reqs)
     except BlockingIOError:
         return 0
     except (IOError, ConnectionRefusedError):
diff --git a/tests/data/tickets.json b/tests/data/tickets.json
index 177f15a..52da6d9 100644
--- a/tests/data/tickets.json
+++ b/tests/data/tickets.json
@@ -1 +1 @@
-{"admin":false,"assigned":58,"instance":"0774b9be-ca96-11e5-b59e-7365ce69eb31","ircnick":"","next":"limit=2&page=2","nickname":"","prev":"","requests":[{"artifacts":"https://ci-train.ubuntu.com/job/ubuntu-landing-029-1-build/lastBuild/","autopkgtest":"","britney_signoff":"","creator":"renatofilho","date":"2016-02-03T14:16:24.162764Z","description":"Fix bug #1450252","dest":"","distribution":"ubuntu","download_links":"","job_log":"https://ci-train.ubuntu.com/job/ubuntu-landing-029-0-status/4847/consoleFull","lander_signoff":"","landers":"renatofilho","published_versions":"{}","qa_signoff":"Required","request_id":961,"series":"xenial+vivid","siloname":"ubuntu/landing-029","sources":"address-book-app","status":"Successfully built","status_color":"black","sync_request":"","test_plan":"https://wiki.ubuntu.com/Process/Merges/TestPlan/address-book-app"},{"artifacts":"https://ci-train.ubuntu.com/job/ubuntu-landing-046-1-build/lastBuild/","autopkgtest":"/static/britney/xenial/landing-046/excuses.html\\n/static/britney/vivid/landing-046/excuses.html","britney_signoff":"Running","creator":"cjwatson","date":"2016-02-03T11:09:13.734136Z","description":"Click 0.4.43: More autopkgtest fixes, and rename python3-click out of the way of the PyPI \"click\" package.","dest":"","distribution":"ubuntu","download_links":"","job_log":"https://ci-train.ubuntu.com/job/ubuntu-landing-046-0-status/4831/consoleFull","lander_signoff":"Approved","landers":"cjwatson","published_versions":"{}","qa_signoff":"Required","request_id":960,"series":"xenial+vivid","siloname":"ubuntu/landing-046","sources":"click","status":"Successfully built","status_color":"black","sync_request":"","test_plan":"https://wiki.ubuntu.com/Process/Merges/TestPlan/click"}],"teams":""}
+{"admin":false,"assigned":58,"instance":"0774b9be-ca96-11e5-b59e-7365ce69eb31","ircnick":"","next":"limit=2&page=2","nickname":"","prev":"","requests":[{"artifacts":"https://ci-train.ubuntu.com/job/ubuntu-landing-029-1-build/lastBuild/","autopkgtest":"","britney_signoff":"", "creator":"renatofilho","date":"2016-02-03T14:16:24.162764Z","description":"Fix bug #1450252","dest":"","distribution":"ubuntu","download_links":"","job_log":"https://ci-train.ubuntu.com/job/ubuntu-landing-029-0-status/4847/consoleFull","lander_signoff":"","landers":"renatofilho","published_versions":"{}","qa_signoff":"Required","request_id":961,"series":"xenial+vivid","siloname":"ubuntu/landing-029","sources":"address-book-app","status":"Successfully built","status_color":"black","sync_request":"","test_plan":"https://wiki.ubuntu.com/Process/Merges/TestPlan/address-book-app"},{"artifacts":"https://ci-train.ubuntu.com/job/ubuntu-landing-046-1-build/lastBuild/","autopkgtest":"/static/britney/xenial/landing-046/excuses.html\\n/static/britney/vivid/landing-046/excuses.html","britney_signoff":"Running","creator":"cjwatson","date":"2016-02-03T11:09:13.734136Z","description":"Click 0.4.43: More autopkgtest fixes, and rename python3-click out of the way of the PyPI \"click\" package.","dest":"","distribution":"ubuntu","download_links":"","job_log":"https://ci-train.ubuntu.com/job/ubuntu-landing-046-0-status/4831/consoleFull","lander_signoff":"Approved","landers":"cjwatson","published_versions":"{}","qa_signoff":"Required","request_id":960,"series":"xenial+vivid","siloname":"ubuntu/landing-046","sources":"click","status":"Successfully built","status_color":"black","sync_request":"","test_plan":"https://wiki.ubuntu.com/Process/Merges/TestPlan/click"}],"teams":""}
diff --git a/tests/test_ust.py b/tests/test_ust.py
new file mode 100644
index 0000000..0daa6df
--- /dev/null
+++ b/tests/test_ust.py
@@ -0,0 +1,26 @@
+"""UST tests"""
+
+from os.path import join, dirname
+from json import loads
+from unittest import TestCase
+
+from unittest.mock import patch
+
+from britney.iterate import compute_ust_signoff
+
+DATA_DIR = join(dirname(__file__), 'data')
+
+
+class TestUstIterate(TestCase):
+    """Test the ust method within the iterate.py script."""
+
+    def setUp(self):
+        with open(join(DATA_DIR, 'tickets.json'), 'r',
+                  encoding='utf-8') as ticketsfp:
+            self.requests = loads(ticketsfp.read())['requests']
+
+    @patch('qakit.ust.worker.Worker.run_ust')
+    def test_ust_triggered_for_lander_approved_only(self, worker):
+        compute_ust_signoff(self.requests)
+        self.assertTrue(worker.called)
+        self.assertEqual(worker.call_count, 1)