Merge lp:~sbaldassin/autopilot-qt/snapping_autopilot_qt into lp:autopilot-qt

[Santiago Baldassin]

Snapping autopilot qt

This mp adds the snapcraft.yaml to snap autopilot-qt

Within the yaml a contant sharing slot has been defined so that any snap aiming to use autopilot_qt to allow the introspection, will have to plug to such a slot

[Omer Akram (om26er)]

The build failed for me http://paste.ubuntu.com/23420692/

Project ERROR: Package xpathselect not found <-- this error is of interest.

review: Needs Fixing

[Omer Akram (om26er)]

the build was successful after your latest changes. I added minor inline comments.

review: Needs Fixing

[Sergio Cazzolato (sergio-j-cazzolato)]

It works and code lgtm. I compiled and tests that in xenial + overlay.

review: Approve

[Omer Akram (om26er)]

LGTM as well ;)

review: Approve

[Heber Parrucci (heber013)]

Code LGTM, I was able to generate and install the snap using --devmode. The testability interface was exposed properly in slots section.

review: Approve

[Sergio Cazzolato (sergio-j-cazzolato)]

g++ is needed to compile qt5 in arm64 architecture

review: Needs Fixing

[Sergio Cazzolato (sergio-j-cazzolato)]

I am getting this warning when I run snapcraft

Use of pull-properties in the schema is deprecated.
Plugins should now implement get_pull_properties
Use of build-properties in the schema is deprecated.
Plugins should now implement get_build_properties
Use of pull-properties in the schema is deprecated.
Plugins should now implement get_pull_properties
Use of build-properties in the schema is deprecated.
Plugins should now implement get_build_properties

review: Needs Fixing

[lp:~sbaldassin/autopilot-qt/snapping_autopilot_qt]

99. By Santiago Baldassin on 2017-01-17

Adding g++

[Sergio Cazzolato (sergio-j-cazzolato)]

with g++ as dep the snap can be created in arm64 and amd 64 as well

review: Approve

=== modified file 'lib/lib.pro'
--- lib/lib.pro	2013-01-14 12:58:15 +0000
+++ lib/lib.pro	2017-01-17 13:10:43 +0000
@@ -12,4 +12,5 @@
 HEADERS = qttestability.h
 
 target.file = libtestability*
+
 INSTALLS += target

=== added file 'snapcraft.yaml'
--- snapcraft.yaml	1970-01-01 00:00:00 +0000
+++ snapcraft.yaml	2017-01-17 13:10:43 +0000
@@ -0,0 +1,49 @@
+name: autopilot-qt
+version: 1.4
+summary: Autopilot QT
+grade: stable
+description: |
+  This project makes Qt applications introspectable by autopilot when started with the -testability flag.
+  This allows autopilot to test any existing Qt application, without having to rebuild the application
+  under test.
+
+confinement: strict
+
+slots:
+  testability:
+    content: testability
+    interface: content
+    read:
+      - usr/lib
+
+parts:
+  autopilot-qt5:
+    plugin: qmake
+    qt-version: qt5
+    source: .
+    build-packages: ['g++', 'debhelper', 'libgl1-mesa-dev', 'libgles2-mesa-dev', 'libqt4-dev', 'libxpathselect-dev', 'mesa-common-dev', 'pkg-config', 'qt4-qmake', 'qt5-qmake', 'qtbase5-dev', 'qtchooser', 'qtdeclarative5-dev', 'xvfb']
+    stage-packages:
+      - libxpathselect1.4v5
+    filesets:
+       libs:
+        - usr/lib/*/libxpathselect*
+        - usr/lib/libautopilot_driver_qt5.so*
+        - usr/lib/libqttestability*
+    stage:
+      - $libs
+    snap:
+      - $libs
+
+  autopilot-qt4:
+    plugin: qmake
+    qt-version: qt4
+    source: .
+    build-packages:
+      - libxpathselect-dev
+    filesets:
+       libs:
+        - usr/lib/libautopilot_driver_qt4.so*
+    stage:
+      - $libs
+    snap:
+      - $libs