OpenUpgrade Addons

Merge lp:~savoirfairelinux/openupgrade-addons/document_page_ir_model_data into lp:openupgrade-addons

  1. document_page_ir_model_data
  2. Merge into 7.0
Status: Merged
Merge reported by: Holger Brunn (Therp)
Merged at revision: not available
Proposed branch: lp:~savoirfairelinux/openupgrade-addons/document_page_ir_model_data
Merge into: lp:openupgrade-addons
To merge this branch: bzr merge lp:~savoirfairelinux/openupgrade-addons/document_page_ir_model_data
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Pedro Manuel Baeza code review Approve
Maxime Chambreuil (http://www.savoirfairelinux.com) (community) Approve
Review via email: mp+231615@code.launchpad.net
To post a comment you must log in.
Revision history for this message
Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote :

For some reason, the diff is not showing... here's the changes done:

http://bazaar.launchpad.net/~savoirfairelinux/openupgrade-addons/document_page_ir_model_data/revision/8166?start_revid=8166

Revision history for this message
Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903) :
review: Approve
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Can you annotate on a _work file the analysis you have done for making this script, as we have made in other modules (it's very helpful)?: http://bazaar.launchpad.net/~openupgrade-committers/openupgrade-addons/7.0/view/head:/stock/migrations/7.0.1.1/openupgrade_analysis_work.txt

The script itself LGTM.

Revision history for this message
Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote :

@Pedro: done in http://bazaar.launchpad.net/~savoirfairelinux/openupgrade-addons/document_page_ir_model_data/revision/8166?start_revid=8167

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

OK, thanks.

review: Approve (code review)
Revision history for this message
Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote :

Diff:

http://bazaar.launchpad.net/~savoirfairelinux/openupgrade-addons/document_page_ir_model_data/revision/8167?start_revid=8165&remember=8165&compare_revid=8165

Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)
Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

This branch is seriously screwed up... I did
bzr diff lp:~savoirfairelinux/openupgrade-addons/document_page_ir_model_data -r -3.. | patch -p0
and will mark the branch as merged by hand.

Subscribers

People subscribed via source and target branches