Merge lp:~savoirfairelinux-openerp/partner-contact-management/user-firstname into lp:~partner-contact-core-editors/partner-contact-management/7.0

Status: Merged
Approved by: Holger Brunn (Therp)
Approved revision: 36
Merged at revision: 36
Proposed branch: lp:~savoirfairelinux-openerp/partner-contact-management/user-firstname
Merge into: lp:~partner-contact-core-editors/partner-contact-management/7.0
Diff against target: 36 lines (+16/-3)
1 file modified
partner_firstname/res_user_view.xml (+16/-3)
To merge this branch: bzr merge lp:~savoirfairelinux-openerp/partner-contact-management/user-firstname
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Jonathan Nemry (Acsone) (community) code review Approve
Yannick Vaucher @ Camptocamp code review, no tests Approve
Pedro Manuel Baeza code review Approve
Review via email:

Description of the change

Adapt user form to look like partner form
* Name field replaced by Firstname and Lastname

To post a comment you must log in.
36. By Sandy Carter (

Adapt user form to display first name and last name like partner form

Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :


review: Approve (code review)
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

Thanks for the contrib, LGTM

review: Approve (code review, no tests)
Revision history for this message
Jonathan Nemry (Acsone) (nemry) wrote :


review: Approve (code review)
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'partner_firstname/res_user_view.xml'
2--- partner_firstname/res_user_view.xml 2014-01-22 15:46:07 +0000
3+++ partner_firstname/res_user_view.xml 2014-03-12 23:29:57 +0000
4@@ -1,16 +1,29 @@
5 <?xml version="1.0" encoding="utf-8"?>
6 <openerp>
7 <data>
9+ <!-- Replace name with first name and last name -->
10 <record id="view_users_form" model="ir.ui.view">
11 <field name="name">res.users.form.firstname</field>
12 <field name="model">res.users</field>
13 <field name="inherit_id" ref="base.view_users_form"/>
14 <field name="arch" type="xml">
15- <field name="name" position="attributes">
16- <attribute name="readonly">False</attribute>
17- <attribute name="required">True</attribute>
19+ <label for="name" position="replace">
20+ <label for="firstname" class="oe_edit_only"/>
21+ </label>
23+ <field name="name" position="replace">
24+ <field name="firstname"/>
25 </field>
27+ <label for="login" position="before">
28+ <label for="lastname" class="oe_edit_only"/>
29+ <h1><field name="lastname"/></h1>
30+ </label>
32 </field>
33 </record>
35 </data>
36 </openerp>