Merge lp:~savoirfairelinux-openerp/partner-contact-management/partner_category_description into lp:~partner-contact-core-editors/partner-contact-management/7.0
Proposed by
Mathieu Benoit
Status: | Superseded |
---|---|
Proposed branch: | lp:~savoirfairelinux-openerp/partner-contact-management/partner_category_description |
Merge into: | lp:~partner-contact-core-editors/partner-contact-management/7.0 |
Diff against target: |
212 lines (+172/-0) 6 files modified
partner_category_description/__init__.py (+21/-0) partner_category_description/__openerp__.py (+49/-0) partner_category_description/i18n/fr.po (+28/-0) partner_category_description/i18n/partner_category_description.pot (+27/-0) partner_category_description/res_partner.py (+29/-0) partner_category_description/res_partner_view.xml (+18/-0) |
To merge this branch: | bzr merge lp:~savoirfairelinux-openerp/partner-contact-management/partner_category_description |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Joao Alfredo Gama Batista | code review, no tests | Needs Fixing | |
Sandy Carter (http://www.savoirfairelinux.com) | Pending | ||
Partner and Contact Core Editors | Pending | ||
Review via email: mp+212507@code.launchpad.net |
This proposal has been superseded by a proposal from 2014-04-01.
Description of the change
Add field description to partner.category.
To post a comment you must log in.
Unmerged revisions
- 40. By Mathieu Benoit
-
[FIX] partner_
category_ description: replace osv to orm. Add new id to view_partner_ category_ form - 39. By Mathieu Benoit
-
[FIX] partner_
category_ description: fix pep8 - 38. By Mathieu Benoit
-
[ADD] partner_
category_ description: add field description translatable
Hi Mathieu,
Thanks for your contribution.
Here's my review:
l.172 Please use orm instead of osv.
l.175 osv.Model -> orm.Model
l.192 It's not a good idea to override a view's external id. Please pick another name for the id.