Merge lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account into lp:~partner-contact-core-editors/partner-contact-management/7.0

[El Hadji Dem (http://www.savoirfairelinux.com)]

Add res_bank_account module: add the title bank account, observation and active boolean fields.It allows to manage several bank accounts for each contact

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

review: Approve (code review, test)

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

Community, any update on this?

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

_columns = {
237 + 'title_bank_account': fields.char('Title bank account', size=256,
238 + help="Title bank account."),
239 + 'observation': fields.text('Observation', help="Observation."),
240 + 'active': fields.boolean('Active', help="Active/Inactive."),
241 + }
242 +

help text are not very helpful :)

review: Needs Fixing

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

What is the purpose of this module ? the description doesn't help either :/

[lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_res_bank_account]

34. By Sandy Carter (http://www.savoirfairelinux.com) on 2014-03-21

Clarified help and description of module

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

Help text and description improved.
I hope this helps for further review.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Description seems inaccurate to me, OpenERP already allows to manage multiple bank account per partner.

What is the plus-value when installing this module?
I suppose this is to add details on bank accounts to describe for what they should be used.
Why should I need a title_bank_account and an observation field on my res_partner_bank
Wouldn't one field be enough?
If I needed more info on res.partner.bank, I would simply add a 'description' field as on other models

title_bank_account seems useless to me as it isn't even in tree views.

Active field already exists on res.partner.bank model. By the way you overide the select=True parameter on it.

And finally this may be a matter of taste but I would name this module res_partner_bank_imp instead.

Thus sorry but I'll disaprove this one in that state.

review: Disapprove

[Ana Juaristi Olalde (ajuaristio)]

@yannick
title_bank_account seems useless to me as it isn't even in tree views.

This is a subjective opinion. If someone needs 2 fields, he adds 2 fields. That's all :)

@Elhadji
My oppinion is Need fixing because:

1. <field name="bank_ids" position="replace">
If you replace bank_ids with something hardcoded on your module view, you will not see new "future" core improvements on that view.

2. I agree with @yannick in --> Active field already exists on res.partner.bank model. By the way you overide the select=True parameter on it.

review: Needs Fixing

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Thanks for the review Ana

My point about title_bank_account is that most of Models have standard `name` and `description` fields.
I agree having a second field description is quiet useful to add note on the object when you open it.

However as res.partner.bank is already a bank account, naming a field xxx_bank_account seams also redundant. Thus I think it is badly named.

Still, module description doesn't match what the module does. This is more about adding fields for informations than allowing to manage multiple bank accounts. Or am I missing something?

[Lorenzo Battistini (elbati)]

This project is now hosted on https://github.com/OCA/partner-contact. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Unmerged revisions

34. By Sandy Carter (http://www.savoirfairelinux.com) on 2014-03-21

Clarified help and description of module

33. By El Hadji Dem (http://www.savoirfairelinux.com) on 2014-01-30

[ADD]Add res_bank_account module: add the title bank account, observation and active boolean fields.It allows to manage several bank accounts for each contact

=== added directory 'res_bank_account'
=== added file 'res_bank_account/__init__.py'
--- res_bank_account/__init__.py	1970-01-01 00:00:00 +0000
+++ res_bank_account/__init__.py	2014-03-21 19:34:54 +0000
@@ -0,0 +1,25 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2013 Savoir-faire Linux
+#    (<http://www.savoirfairelinux.com>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from . import res_bank
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'res_bank_account/__openerp__.py'
--- res_bank_account/__openerp__.py	1970-01-01 00:00:00 +0000
+++ res_bank_account/__openerp__.py	2014-03-21 19:34:54 +0000
@@ -0,0 +1,54 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2010 - 2014 Savoir-faire Linux
+#    (<http://www.savoirfairelinux.com>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': 'Bank Account',
+    'version': '0.1',
+    'author': 'Savoir-faire Linux',
+    'maintainer': 'Savoir-faire Linux',
+    'website': 'http://www.savoirfairelinux.com',
+    'category': 'Customer Relationship Management',
+    'description': """
+Bank Account
+============
+
+This module allows to manage multiple bank accounts for a specific contact.
+
+It adds a bank account object linked to a bank with a name for the account, a
+description and wheter it is active or not.
+
+
+Contributors
+------------
+* El Hadji Dem ([e-mail])
+""",
+    'depends': [
+        'account',
+    ],
+    'external_dependencies': {},
+    'data': [
+        'res_bank_view.xml',
+    ],
+    'demo': [],
+    'test': [],
+    'installable': True,
+}

=== added directory 'res_bank_account/i18n'
=== added file 'res_bank_account/i18n/fr.po'
--- res_bank_account/i18n/fr.po	1970-01-01 00:00:00 +0000
+++ res_bank_account/i18n/fr.po	2014-03-21 19:34:54 +0000
@@ -0,0 +1,52 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+# 	* res_bank_account
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-01-03 07:26+0000\n"
+"PO-Revision-Date: 2014-01-03 02:26-0500\n"
+"Last-Translator: EL Hadji DEM <[e-mail]>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: \n"
+"X-Generator: Poedit 1.5.4\n"
+
+#. module: res_bank_account
+#: field:res.partner.bank,observation:0
+msgid "Observation"
+msgstr "Remarque"
+
+#. module: res_bank_account
+#: help:res.partner.bank,active:0
+msgid "Active/Inactive."
+msgstr "Actif/Inactif."
+
+#. module: res_bank_account
+#: model:ir.model,name:res_bank_account.model_res_partner_bank
+msgid "Bank Accounts"
+msgstr "Comptes bancaires"
+
+#. module: res_bank_account
+#: help:res.partner.bank,observation:0
+msgid "Observation."
+msgstr "Remarque."
+
+#. module: res_bank_account
+#: field:res.partner.bank,title_bank_account:0
+msgid "Title bank account"
+msgstr "Intitulé du compte bancaire"
+
+#. module: res_bank_account
+#: field:res.partner.bank,active:0
+msgid "Active"
+msgstr "Active"
+
+#. module: res_bank_account
+#: help:res.partner.bank,title_bank_account:0
+msgid "Title bank account."
+msgstr "Intitulé du compte bancaire."

=== added file 'res_bank_account/i18n/res_bank_account.pot'
--- res_bank_account/i18n/res_bank_account.pot	1970-01-01 00:00:00 +0000
+++ res_bank_account/i18n/res_bank_account.pot	2014-03-21 19:34:54 +0000
@@ -0,0 +1,52 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+# 	* res_bank_account
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-01-03 07:25+0000\n"
+"PO-Revision-Date: 2014-01-03 02:25-0500\n"
+"Last-Translator: EL Hadji DEM <[e-mail]>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: \n"
+"X-Generator: Poedit 1.5.4\n"
+
+#. module: res_bank_account
+#: field:res.partner.bank,observation:0
+msgid "Observation"
+msgstr ""
+
+#. module: res_bank_account
+#: help:res.partner.bank,active:0
+msgid "Active/Inactive."
+msgstr ""
+
+#. module: res_bank_account
+#: model:ir.model,name:res_bank_account.model_res_partner_bank
+msgid "Bank Accounts"
+msgstr ""
+
+#. module: res_bank_account
+#: help:res.partner.bank,observation:0
+msgid "Observation."
+msgstr ""
+
+#. module: res_bank_account
+#: field:res.partner.bank,title_bank_account:0
+msgid "Title bank account"
+msgstr ""
+
+#. module: res_bank_account
+#: field:res.partner.bank,active:0
+msgid "Active"
+msgstr ""
+
+#. module: res_bank_account
+#: help:res.partner.bank,title_bank_account:0
+msgid "Title bank account."
+msgstr ""

=== added file 'res_bank_account/res_bank.py'
--- res_bank_account/res_bank.py	1970-01-01 00:00:00 +0000
+++ res_bank_account/res_bank.py	2014-03-21 19:34:54 +0000
@@ -0,0 +1,36 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2010 - 2014 Savoir-faire Linux
+#    (<http://www.savoirfairelinux.com>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import orm, fields
+
+
+class res_partner_bank(orm.Model):
+    """Bank account"""
+    _inherit = 'res.partner.bank'
+
+    _columns = {
+        'title_bank_account': fields.char(
+            'Title bank account', size=256, help="Name for the bank account."),
+        'observation': fields.text(
+            'Observation',  help="Extra information about the account."),
+        'active': fields.boolean('Active', help="Whether the account is still active or not."),
+    }

=== added file 'res_bank_account/res_bank_view.xml'
--- res_bank_account/res_bank_view.xml	1970-01-01 00:00:00 +0000
+++ res_bank_account/res_bank_view.xml	2014-03-21 19:34:54 +0000
@@ -0,0 +1,61 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+    <data>
+
+      <!-- Adds title_bank_account,observation and active fields in res.bank form view -->
+      <record id="view_partner_bank_inherit_add_form" model="ir.ui.view">
+        <field name="name">res.partner.bank.inherit.add.form</field>
+        <field name="model">res.partner.bank</field>
+        <field name="inherit_id" ref="base.view_partner_bank_form"/>
+        <field name="arch" type="xml">
+          <field name="state" position="before">
+              <field name="title_bank_account"/>
+          </field>
+          <field name="acc_number" position="after">
+              <field name="active"/>
+          </field>
+          <xpath expr="//form[@string='Bank account']/group[2]"
+               position="after">
+           <group>
+              <field name="observation"/>
+           </group>
+        </xpath>
+        </field>
+      </record>
+
+      <!--Add active field in tree view-->
+      <record id="view_partner_bank_inherit_active_tree" model="ir.ui.view">
+        <field name="name">res.partner.bank.inherit.active.tree</field>
+        <field name="model">res.partner.bank</field>
+        <field name="inherit_id" ref="base.view_partner_bank_tree"/>
+        <field name="arch" type="xml">
+          <field name="state" position="before">
+              <field name="active"/>
+          </field>
+        </field>
+      </record>
+
+      <!--redefine bank_ids tree-->
+    <record id="view_partner_property_bank_form" model="ir.ui.view">
+      <field name="name">res.partner.property.bank.inherit.bank.form</field>
+      <field name="model">res.partner</field>
+      <field name="inherit_id" ref="account.view_partner_property_form"/>
+      <field name="arch" type="xml">
+        <!--redefine bank_ids tree-->
+        <field name="bank_ids" position="replace">
+          <field name="bank_ids"
+                 context="{'default_partner_id': active_id, 'form_view_ref': 'base.view_partner_bank_form'}">
+            <tree string="Bank Details">
+              <field name="active"/>
+              <field name="state" invisible="1"/>
+              <field name="sequence" invisible="1"/>
+              <field name="acc_number"/>
+              <field name="bank_name"/>
+              <field name="owner_name"/>
+            </tree>
+          </field>
+        </field>
+      </field>
+    </record>
+    </data>
+</openerp>