Merge lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name into lp:~partner-contact-core-editors/partner-contact-management/7.0

Status: Needs review
Proposed branch: lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name
Merge into: lp:~partner-contact-core-editors/partner-contact-management/7.0
Diff against target: 221 lines (+190/-0)
6 files modified
partner_maiden_name/__init__.py (+25/-0)
partner_maiden_name/__openerp__.py (+53/-0)
partner_maiden_name/i18n/fr.po (+32/-0)
partner_maiden_name/i18n/partner_maiden_name.pot (+32/-0)
partner_maiden_name/res_partner.py (+32/-0)
partner_maiden_name/res_partner_view.xml (+16/-0)
To merge this branch: bzr merge lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name
Reviewer Review Type Date Requested Status
Lorenzo Battistini - Agile BG (community) Resubmit on 2014-07-23
Sandy Carter (http://www.savoirfairelinux.com) Needs Fixing on 2014-04-11
Yannick Vaucher @ Camptocamp 2014-01-30 Needs Fixing on 2014-04-11
Partner and Contact Core Editors 2014-03-21 Pending
Review via email: mp+204023@code.launchpad.net

Description of the change

-Add partner_maiden_name module: It allows to add the maiden name field to the partner.

To post a comment you must log in.

Maybe rename the module and the field by "Previous name" or "birth name" as maiden name is

For now I won't approve it as there is a talk on firstname in community mailing list

review: Needs Information

Thanks for your comment. We decided to keep it.

There is a talk on firstname, I met some issues with this module and I decided to redefine the module.
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner_firstname_lastname

Firstname has been implemented by lp:~acsone-openerp/partner-contact-management/7.0-partner-firstname

@Yannick, can you rexplain your objection, it seems to have been cut off: «as maiden name is» ...

review: Approve

Sorry indeed something is missing

Thanks for the reminder

Correct me if I'm wrong but Maiden name is sexist and not accurate nor generic nowadays.

You should find enough altenatives with:
Maiden name -> birth name, surname at birth, original name, former name

review: Needs Fixing

@Yannick,
Thank you for pointing that out. Indeed, maiden name might be a charged, non-gender neutral name for the field and should be changed.

review: Needs Fixing

This project is now hosted on https://github.com/OCA/partner-contact. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Resubmit

Unmerged revisions

33. By El Hadji Dem (http://www.savoirfairelinux.com) on 2014-01-30

[ADD] add partner_maiden_name module: It allows to add the maiden name field to the partner

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== added directory 'partner_maiden_name'
2=== added file 'partner_maiden_name/__init__.py'
3--- partner_maiden_name/__init__.py 1970-01-01 00:00:00 +0000
4+++ partner_maiden_name/__init__.py 2014-01-30 16:31:08 +0000
5@@ -0,0 +1,25 @@
6+# -*- encoding: utf-8 -*-
7+##############################################################################
8+#
9+# OpenERP, Open Source Management Solution
10+# This module copyright (C) 2013 Savoir-faire Linux
11+# (<http://www.savoirfairelinux.com>).
12+#
13+# This program is free software: you can redistribute it and/or modify
14+# it under the terms of the GNU Affero General Public License as
15+# published by the Free Software Foundation, either version 3 of the
16+# License, or (at your option) any later version.
17+#
18+# This program is distributed in the hope that it will be useful,
19+# but WITHOUT ANY WARRANTY; without even the implied warranty of
20+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
21+# GNU Affero General Public License for more details.
22+#
23+# You should have received a copy of the GNU Affero General Public License
24+# along with this program. If not, see <http://www.gnu.org/licenses/>.
25+#
26+##############################################################################
27+
28+from . import res_partner
29+
30+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
31
32=== added file 'partner_maiden_name/__openerp__.py'
33--- partner_maiden_name/__openerp__.py 1970-01-01 00:00:00 +0000
34+++ partner_maiden_name/__openerp__.py 2014-01-30 16:31:08 +0000
35@@ -0,0 +1,53 @@
36+# -*- encoding: utf-8 -*-
37+##############################################################################
38+#
39+# OpenERP, Open Source Management Solution
40+# This module copyright (C) 2013 Savoir-faire Linux
41+# (<http://www.savoirfairelinux.com>).
42+#
43+# This program is free software: you can redistribute it and/or modify
44+# it under the terms of the GNU Affero General Public License as
45+# published by the Free Software Foundation, either version 3 of the
46+# License, or (at your option) any later version.
47+#
48+# This program is distributed in the hope that it will be useful,
49+# but WITHOUT ANY WARRANTY; without even the implied warranty of
50+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
51+# GNU Affero General Public License for more details.
52+#
53+# You should have received a copy of the GNU Affero General Public License
54+# along with this program. If not, see <http://www.gnu.org/licenses/>.
55+#
56+##############################################################################
57+
58+{
59+ 'name': 'Partner Maiden Name',
60+ 'version': '0.1',
61+ 'author': 'Savoir-faire Linux',
62+ 'maintainer': 'Savoir-faire Linux',
63+ 'website': 'http://www.savoirfairelinux.com',
64+ 'category': 'MISC',
65+ 'description': """
66+Partner Maiden Name
67+===================
68+
69+This module allows you to add maiden name
70+
71+Contributors
72+------------
73+* EL HADJI DEM (elhadji.dem@savoirfairelinux.com)
74+""",
75+ 'depends': [
76+ 'base',
77+ ],
78+ 'external_dependencies': {},
79+ 'data': [
80+ 'res_partner_view.xml',
81+ ],
82+ 'demo': [],
83+ 'test': [],
84+ 'installable': True,
85+ 'active': False,
86+}
87+
88+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
89
90=== added directory 'partner_maiden_name/i18n'
91=== added file 'partner_maiden_name/i18n/fr.po'
92--- partner_maiden_name/i18n/fr.po 1970-01-01 00:00:00 +0000
93+++ partner_maiden_name/i18n/fr.po 2014-01-30 16:31:08 +0000
94@@ -0,0 +1,32 @@
95+# Translation of OpenERP Server.
96+# This file contains the translation of the following modules:
97+# * partner_maiden_name
98+#
99+msgid ""
100+msgstr ""
101+"Project-Id-Version: OpenERP Server 7.0\n"
102+"Report-Msgid-Bugs-To: \n"
103+"POT-Creation-Date: 2014-01-03 07:40+0000\n"
104+"PO-Revision-Date: 2014-01-03 02:40-0500\n"
105+"Last-Translator: EL Hadji DEM <elhadji.dem@savoirfairelinux.com>\n"
106+"Language-Team: \n"
107+"MIME-Version: 1.0\n"
108+"Content-Type: text/plain; charset=UTF-8\n"
109+"Content-Transfer-Encoding: 8bit\n"
110+"Plural-Forms: \n"
111+"X-Generator: Poedit 1.5.4\n"
112+
113+#. module: partner_maiden_name
114+#: help:res.partner,maiden_name:0
115+msgid "Maiden name."
116+msgstr "Nom de jeune fille."
117+
118+#. module: partner_maiden_name
119+#: view:res.partner:0 field:res.partner,maiden_name:0
120+msgid "Maiden name"
121+msgstr "Nom de jeune fille"
122+
123+#. module: partner_maiden_name
124+#: model:ir.model,name:partner_maiden_name.model_res_partner
125+msgid "Partner"
126+msgstr "Partenaire"
127
128=== added file 'partner_maiden_name/i18n/partner_maiden_name.pot'
129--- partner_maiden_name/i18n/partner_maiden_name.pot 1970-01-01 00:00:00 +0000
130+++ partner_maiden_name/i18n/partner_maiden_name.pot 2014-01-30 16:31:08 +0000
131@@ -0,0 +1,32 @@
132+# Translation of OpenERP Server.
133+# This file contains the translation of the following modules:
134+# * partner_maiden_name
135+#
136+msgid ""
137+msgstr ""
138+"Project-Id-Version: OpenERP Server 7.0\n"
139+"Report-Msgid-Bugs-To: \n"
140+"POT-Creation-Date: 2014-01-03 07:39+0000\n"
141+"PO-Revision-Date: 2014-01-03 02:39-0500\n"
142+"Last-Translator: EL Hadji DEM <elhadji.dem@savoirfairelinux.com>\n"
143+"Language-Team: \n"
144+"MIME-Version: 1.0\n"
145+"Content-Type: text/plain; charset=UTF-8\n"
146+"Content-Transfer-Encoding: 8bit\n"
147+"Plural-Forms: \n"
148+"X-Generator: Poedit 1.5.4\n"
149+
150+#. module: partner_maiden_name
151+#: help:res.partner,maiden_name:0
152+msgid "Maiden name."
153+msgstr ""
154+
155+#. module: partner_maiden_name
156+#: view:res.partner:0 field:res.partner,maiden_name:0
157+msgid "Maiden name"
158+msgstr ""
159+
160+#. module: partner_maiden_name
161+#: model:ir.model,name:partner_maiden_name.model_res_partner
162+msgid "Partner"
163+msgstr ""
164
165=== added file 'partner_maiden_name/res_partner.py'
166--- partner_maiden_name/res_partner.py 1970-01-01 00:00:00 +0000
167+++ partner_maiden_name/res_partner.py 2014-01-30 16:31:08 +0000
168@@ -0,0 +1,32 @@
169+# -*- encoding: utf-8 -*-
170+##############################################################################
171+#
172+# OpenERP, Open Source Management Solution
173+# This module copyright (C) 2013 Savoir-faire Linux
174+# (<http://www.savoirfairelinux.com>).
175+#
176+# This program is free software: you can redistribute it and/or modify
177+# it under the terms of the GNU Affero General Public License as
178+# published by the Free Software Foundation, either version 3 of the
179+# License, or (at your option) any later version.
180+#
181+# This program is distributed in the hope that it will be useful,
182+# but WITHOUT ANY WARRANTY; without even the implied warranty of
183+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
184+# GNU Affero General Public License for more details.
185+#
186+# You should have received a copy of the GNU Affero General Public License
187+# along with this program. If not, see <http://www.gnu.org/licenses/>.
188+#
189+##############################################################################
190+
191+from openerp.osv import orm, fields
192+
193+
194+class res_partner(orm.Model):
195+ _inherit = 'res.partner'
196+ _columns = {
197+ 'maiden_name': fields.char('Maiden name', size=256, help="Maiden name."),
198+ }
199+
200+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
201
202=== added file 'partner_maiden_name/res_partner_view.xml'
203--- partner_maiden_name/res_partner_view.xml 1970-01-01 00:00:00 +0000
204+++ partner_maiden_name/res_partner_view.xml 2014-01-30 16:31:08 +0000
205@@ -0,0 +1,16 @@
206+<?xml version="1.0" encoding="utf-8"?>
207+<openerp>
208+ <data>
209+ <!--Add maiden name for contact-->
210+ <record id="view_contact_by_function_maiden_name_form" model="ir.ui.view">
211+ <field name="name">contact.functions.maiden.name.form.inherit</field>
212+ <field name="model">res.partner</field>
213+ <field name="inherit_id" ref="base.view_partner_form"/>
214+ <field name="arch" type="xml">
215+ <field name="category_id" position="before">
216+ <field name="maiden_name" attrs="{'invisible': [('is_company','=', True)]}" placeholder="Maiden name"/>
217+ </field>
218+ </field>
219+ </record>
220+ </data>
221+</openerp>