Merge lp:~savoirfairelinux-openerp/partner-contact-management/partner-contact-management-base_contact_add_partner_maiden_name into lp:~partner-contact-core-editors/partner-contact-management/7.0

[El Hadji Dem (http://www.savoirfairelinux.com)]

-Add partner_maiden_name module: It allows to add the maiden name field to the partner.

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Maybe rename the module and the field by "Previous name" or "birth name" as maiden name is

For now I won't approve it as there is a talk on firstname in community mailing list

review: Needs Information

[El Hadji Dem (http://www.savoirfairelinux.com) (eh-dem)]

Thanks for your comment. We decided to keep it.

There is a talk on firstname, I met some issues with this module and I decided to redefine the module.
https://code.launchpad.net/~savoirfairelinux-openerp/partner-contact-management/partner_firstname_lastname

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

Firstname has been implemented by lp:~acsone-openerp/partner-contact-management/7.0-partner-firstname

@Yannick, can you rexplain your objection, it seems to have been cut off: «as maiden name is» ...

review: Approve

[Yannick Vaucher @ Camptocamp (yvaucher-c2c)]

Sorry indeed something is missing

Thanks for the reminder

Correct me if I'm wrong but Maiden name is sexist and not accurate nor generic nowadays.

You should find enough altenatives with:
Maiden name -> birth name, surname at birth, original name, former name

review: Needs Fixing

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

@Yannick,
Thank you for pointing that out. Indeed, maiden name might be a charged, non-gender neutral name for the field and should be changed.

review: Needs Fixing

[Lorenzo Battistini (elbati)]

This project is now hosted on https://github.com/OCA/partner-contact. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Unmerged revisions

33. By El Hadji Dem (http://www.savoirfairelinux.com) on 2014-01-30

[ADD] add partner_maiden_name module: It allows to add the maiden name field to the partner

=== added directory 'partner_maiden_name'
=== added file 'partner_maiden_name/__init__.py'
--- partner_maiden_name/__init__.py	1970-01-01 00:00:00 +0000
+++ partner_maiden_name/__init__.py	2014-01-30 16:31:08 +0000
@@ -0,0 +1,25 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2013 Savoir-faire Linux
+#    (<http://www.savoirfairelinux.com>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from . import res_partner
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'partner_maiden_name/__openerp__.py'
--- partner_maiden_name/__openerp__.py	1970-01-01 00:00:00 +0000
+++ partner_maiden_name/__openerp__.py	2014-01-30 16:31:08 +0000
@@ -0,0 +1,53 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2013 Savoir-faire Linux
+#    (<http://www.savoirfairelinux.com>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': 'Partner Maiden Name',
+    'version': '0.1',
+    'author': 'Savoir-faire Linux',
+    'maintainer': 'Savoir-faire Linux',
+    'website': 'http://www.savoirfairelinux.com',
+    'category': 'MISC',
+    'description': """
+Partner Maiden Name
+===================
+
+This module allows you to add maiden name
+
+Contributors
+------------
+* EL HADJI DEM ([e-mail])
+""",
+    'depends': [
+        'base',
+    ],
+    'external_dependencies': {},
+    'data': [
+        'res_partner_view.xml',
+    ],
+    'demo': [],
+    'test': [],
+    'installable': True,
+    'active': False,
+}
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added directory 'partner_maiden_name/i18n'
=== added file 'partner_maiden_name/i18n/fr.po'
--- partner_maiden_name/i18n/fr.po	1970-01-01 00:00:00 +0000
+++ partner_maiden_name/i18n/fr.po	2014-01-30 16:31:08 +0000
@@ -0,0 +1,32 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+# 	* partner_maiden_name
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-01-03 07:40+0000\n"
+"PO-Revision-Date: 2014-01-03 02:40-0500\n"
+"Last-Translator: EL Hadji DEM <[e-mail]>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: \n"
+"X-Generator: Poedit 1.5.4\n"
+
+#. module: partner_maiden_name
+#: help:res.partner,maiden_name:0
+msgid "Maiden name."
+msgstr "Nom de jeune fille."
+
+#. module: partner_maiden_name
+#: view:res.partner:0 field:res.partner,maiden_name:0
+msgid "Maiden name"
+msgstr "Nom de jeune fille"
+
+#. module: partner_maiden_name
+#: model:ir.model,name:partner_maiden_name.model_res_partner
+msgid "Partner"
+msgstr "Partenaire"

=== added file 'partner_maiden_name/i18n/partner_maiden_name.pot'
--- partner_maiden_name/i18n/partner_maiden_name.pot	1970-01-01 00:00:00 +0000
+++ partner_maiden_name/i18n/partner_maiden_name.pot	2014-01-30 16:31:08 +0000
@@ -0,0 +1,32 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+# 	* partner_maiden_name
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2014-01-03 07:39+0000\n"
+"PO-Revision-Date: 2014-01-03 02:39-0500\n"
+"Last-Translator: EL Hadji DEM <[e-mail]>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: 8bit\n"
+"Plural-Forms: \n"
+"X-Generator: Poedit 1.5.4\n"
+
+#. module: partner_maiden_name
+#: help:res.partner,maiden_name:0
+msgid "Maiden name."
+msgstr ""
+
+#. module: partner_maiden_name
+#: view:res.partner:0 field:res.partner,maiden_name:0
+msgid "Maiden name"
+msgstr ""
+
+#. module: partner_maiden_name
+#: model:ir.model,name:partner_maiden_name.model_res_partner
+msgid "Partner"
+msgstr ""

=== added file 'partner_maiden_name/res_partner.py'
--- partner_maiden_name/res_partner.py	1970-01-01 00:00:00 +0000
+++ partner_maiden_name/res_partner.py	2014-01-30 16:31:08 +0000
@@ -0,0 +1,32 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2013 Savoir-faire Linux
+#    (<http://www.savoirfairelinux.com>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import orm, fields
+
+
+class res_partner(orm.Model):
+    _inherit = 'res.partner'
+    _columns = {
+        'maiden_name': fields.char('Maiden name', size=256, help="Maiden name."),
+    }
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'partner_maiden_name/res_partner_view.xml'
--- partner_maiden_name/res_partner_view.xml	1970-01-01 00:00:00 +0000
+++ partner_maiden_name/res_partner_view.xml	2014-01-30 16:31:08 +0000
@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>
+  <data>
+    <!--Add maiden name for contact-->
+    <record id="view_contact_by_function_maiden_name_form" model="ir.ui.view">
+      <field name="name">contact.functions.maiden.name.form.inherit</field>
+      <field name="model">res.partner</field>
+      <field name="inherit_id" ref="base.view_partner_form"/>
+      <field name="arch" type="xml">
+        <field name="category_id" position="before">
+           <field name="maiden_name" attrs="{'invisible': [('is_company','=', True)]}" placeholder="Maiden name"/>
+        </field>
+      </field>
+    </record>
+  </data>
+</openerp>