Partner and Contact Management

Merge lp:~savoirfairelinux-openerp/partner-contact-management/1279118 into lp:~partner-contact-core-editors/partner-contact-management/7.0

  1. 1279118
  2. Merge into 7.0
Status: Merged
Approved by: Yannick Vaucher @ Camptocamp
Approved revision: 33
Merged at revision: 33
Proposed branch: lp:~savoirfairelinux-openerp/partner-contact-management/1279118
Merge into: lp:~partner-contact-core-editors/partner-contact-management/7.0
Diff against target: 12 lines (+1/-1)
1 file modified
base_location/better_zip.py (+1/-1)
To merge this branch: bzr merge lp:~savoirfairelinux-openerp/partner-contact-management/1279118
Reviewer Review Type Date Requested Status
Yannick Vaucher @ Camptocamp code review, no tests Approve
Pedro Manuel Baeza Approve
Review via email: mp+205871@code.launchpad.net

Description of the change

Fixes lp:1279118
Adding context propagation.

This is a good example of why context propagation is necessary.

To post a comment you must log in.
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

Indeed, not propagating context can have these side effects.

Regards.

review: Approve
Revision history for this message
Yannick Vaucher @ Camptocamp (yvaucher-c2c) wrote :

LGTM

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'base_location/better_zip.py'
2--- base_location/better_zip.py 2013-12-12 22:38:57 +0000
3+++ base_location/better_zip.py 2014-02-11 23:32:03 +0000
4@@ -42,7 +42,7 @@
5
6 def name_get(self, cursor, uid, ids, context=None):
7 res = []
8- for bzip in self.browse(cursor, uid, ids):
9+ for bzip in self.browse(cursor, uid, ids, context=context):
10 if bzip.name:
11 name = [bzip.name, bzip.city]
12 else: