Merge lp:~savoirfairelinux-openerp/openupgrade-server/base_contact into lp:openupgrade-server
Proposed by
Sandy Carter (http://www.savoirfairelinux.com)
Status: | Merged |
---|---|
Merged at revision: | 4642 |
Proposed branch: | lp:~savoirfairelinux-openerp/openupgrade-server/base_contact |
Merge into: | lp:openupgrade-server |
Diff against target: |
165 lines (+96/-5) 2 files modified
openerp/addons/base/migrations/7.0.1.3/post-migration.py (+80/-4) openerp/addons/base/migrations/7.0.1.3/pre-migration.py (+16/-1) |
To merge this branch: | bzr merge lp:~savoirfairelinux-openerp/openupgrade-server/base_contact |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Pedro Manuel Baeza | code review | Approve | |
Holger Brunn (Therp) | code review | Approve | |
Stefan Rijnhart (Opener) | Approve | ||
Review via email: mp+194762@code.launchpad.net |
Description of the change
Marks base_contact module to be removed.
Moves entries from res_partner_contact to res_partner.
To post a comment you must log in.
Thanks! Looks alright to me, in principle. Two questions:
l.51 and l.78: why do you need to check if the fields exist? Seems to me this could mask potential problems in the current or future version of the code.
l.12: would it not be safer if you checked the status of the entry for 'base_contact' in the ir_module_module table? The table could theoretically belong to another module, or contain deprecated information after a deinstallation of the base_contact module.