Merge lp:~savoirfairelinux-openerp/openupgrade-addons/sale_crm into lp:openupgrade-addons

[Sandy Carter (http://www.savoirfairelinux.com)]

Migrate categ_id to categ_ids

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

review: Approve

[Pedro Manuel Baeza (pedro.baeza)]

Some comments inline

review: Needs Fixing (code review)

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

My explanation

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

Updated typos + had the files at the root instead of in sale_crm

[Pedro Manuel Baeza (pedro.baeza)]

Please refer also in a file user_notes.txt that the migration is not completed.

review: Needs Fixing

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

I don't know if it is incomplete, there are no problems with the new fields.

[Pedro Manuel Baeza (pedro.baeza)]

Well, then put as nothing to do then. The goal is to inform people is there is something still that it hasn't been checked and might need something in the script. If you are sure that the rest of the changes doesn't need it, then put nothing to do and people will know that script is completed.

[Holger Brunn (Therp) (hbrunn)]

Pedro: I don't really understand your last comment. Could you explain what you mean here?

review: Approve (code review)

[Pedro Manuel Baeza (pedro.baeza)]

What I try to say is: if migration script is not completed or you don't know if it's completed, then say it; if it's completed, then say it also.

[Yann Papouin (yann-papouin)]

I'm getting the following error when upgrading from 6.1 and it seems to be related to a workflow trigger:

2014-10-29 15:33:16,648 8281 INFO db OpenUpgrade: sale_crm: post-migration script called with version 6.1.1.0
2014-10-29 15:33:16,772 8281 ERROR db openerp.tools.safe_eval: Cannot eval u"test_state('canceled')"
Traceback (most recent call last):
  File "/home/ubuntu/projects/openupgrade/server/openerp/tools/safe_eval.py", line 241, in safe_eval
    return eval(test_expr(expr, _SAFE_OPCODES, mode=mode), globals_dict, locals_dict)
  File "", line 1, in <module>
NameError: name 'test_state' is not defined
2014-10-29 15:33:16,800 8281 ERROR db OpenUpgrade: sale_crm: error in migration script /home/ubuntu/projects/openupgrade/addons/sale_crm/migrations/7.0.1.0/post-migration.py: name 'test_state' is not defined
2014-10-29 15:33:16,800 8281 ERROR db OpenUpgrade: name 'test_state' is not defined

Traceback (most recent call last):
  File "/home/ubuntu/projects/openupgrade/server/openerp/openupgrade/openupgrade.py", line 473, in wrapped_function
    func(cr, version)
  File "/home/ubuntu/projects/openupgrade/addons/sale_crm/migrations/7.0.1.0/post-migration.py", line 31, in migrate
    openupgrade.get_legacy_name('categ_id'))
  File "/home/ubuntu/projects/openupgrade/server/openerp/openupgrade/openupgrade.py", line 414, in m2o_to_m2m
    model.write(cr, SUPERUSER_ID, row[0], {field: [(4, row[1])]})
  File "/home/ubuntu/projects/openupgrade/addons/mail/mail_thread.py", line 264, in write
    result = super(mail_thread, self).write(cr, uid, ids, values, context=context)
  File "/home/ubuntu/projects/openupgrade/server/openerp/osv/orm.py", line 4299, in write
    self._workflow_trigger(cr, user, ids, 'trg_write', context=context)
  File "/home/ubuntu/projects/openupgrade/server/openerp/osv/orm.py", line 3946, in _workflow_trigger
    getattr(wf_service, trigger)(uid, self._name, res_id, cr)
  File "/home/ubuntu/projects/openupgrade/server/openerp/workflow/wkf_service.py", line 55, in trg_write
    instance.update(cr, id, ident)
  File "/home/ubuntu/projects/openupgrade/server/openerp/workflow/instance.py", line 52, in update
    workitem.process(cr, witem, ident, stack=stack)
  File "/home/ubuntu/projects/openupgrade/server/openerp/workflow/workitem.py", line 60, in process
    ok = _split_test(cr, workitem, activity['split_mode'], ident, signal, stack)
  File "/home/ubuntu/projects/openupgrade/server/openerp/workflow/workitem.py", line 157, in _split_test
    if wkf_expr.check(cr, workitem, ident, transition,signal):
  File "/home/ubuntu/projects/openupgrade/server/openerp/workflow/wkf_expr.py", line 80, in check
    return _eval_expr(cr, ident, workitem, transition['condition'])
  File "/home/ubuntu/projects/openupgrade/server/openerp/workflow/wkf_expr.py", line 57, in _eval_expr
    ret = eval(line, env, nocopy=True)
  File "/home/ubuntu/projects/openupgrade/server/openerp/tools/safe_eval.py", line 241, in safe_eval
    return eval(test_expr(expr, _SAFE_OPCODES, mode=mode), globals_dict, locals_dict)
  File "", line 1, in <module>
NameError: name 'test_state' is not defined

I'm watching into this but any tip to fix this is welcome :)

[Yann Papouin (yann-papouin)]

Ok it is fixed for me.
"test_state" is defined in the "sale_stock" module, so I retry an upgrade by forcing

[openupgrade]
forced_deps = {'sale_crm': ['sale_stock']}

But it was not working, I had to edit the "sale_crm" manifest:
'depends': ['sale', 'crm', 'sale_stock'],

[Stefan Rijnhart (Opener) (stefan-opener)]

@yann thanks for the feedback. I created a bug to track this issue separately: https://bugs.launchpad.net/openupgrade-addons/+bug/1387613

=== added file 'sale_crm/migrations/7.0.1.0/openupgrade_analysis_work.txt'
--- sale_crm/migrations/7.0.1.0/openupgrade_analysis_work.txt	1970-01-01 00:00:00 +0000
+++ sale_crm/migrations/7.0.1.0/openupgrade_analysis_work.txt	2014-09-10 18:44:45 +0000
@@ -0,0 +1,23 @@
+---Fields in module 'sale_crm'---
+
+# Convert from m2o to m2m
+sale_crm     / sale.order               / categ_id (many2one)           : DEL relation: crm.case.categ
+sale_crm     / sale.order               / categ_ids (many2many)         : NEW relation: crm.case.categ
+
+sale_crm     / account.invoice          / section_id (many2one)         : NEW relation: crm.case.section
+sale_crm     / account.invoice.report   / section_id (many2one)         : NEW relation: crm.case.section
+sale_crm     / res.users                / default_section_id (many2one) : NEW relation: crm.case.section
+
+
+---XML records in module 'sale_crm'---
+DEL ir.ui.menu: base.menu_base_partner
+NEW ir.ui.view: sale_crm.account_invoice_form
+NEW ir.ui.view: sale_crm.account_invoice_groupby_inherit
+NEW ir.ui.view: sale_crm.account_invoice_report_tree
+NEW ir.ui.view: sale_crm.account_invoice_tree
+NEW ir.ui.view: sale_crm.res_user_form
+NEW ir.ui.view: sale_crm.view_users_form_preferences
+DEL ir.ui.view: sale_crm.board_crm_form_inherit_replace1
+DEL ir.ui.view: sale_crm.board_crm_form_inherit_replace3
+NEW mail.message.subtype: sale_crm.mt_salesteam_order_confirmed
+NEW mail.message.subtype: sale_crm.mt_salesteam_order_sent

=== added file 'sale_crm/migrations/7.0.1.0/post-migration.py'
--- sale_crm/migrations/7.0.1.0/post-migration.py	1970-01-01 00:00:00 +0000
+++ sale_crm/migrations/7.0.1.0/post-migration.py	2014-09-10 18:44:45 +0000
@@ -0,0 +1,31 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2014 Savoir-faire Linux
+#    (<http://www.savoirfairelinux.com>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp import pooler
+from openupgrade import openupgrade
+
+
[e-mail]()
+def migrate(cr, version):
+    pool = pooler.get_pool(cr.dbname)
+    openupgrade.m2o_to_m2m(cr, pool['sale.order'], 'sale_order', 'categ_ids',
+                           openupgrade.get_legacy_name('categ_id'))

=== added file 'sale_crm/migrations/7.0.1.0/pre-migration.py'
--- sale_crm/migrations/7.0.1.0/pre-migration.py	1970-01-01 00:00:00 +0000
+++ sale_crm/migrations/7.0.1.0/pre-migration.py	2014-09-10 18:44:45 +0000
@@ -0,0 +1,34 @@
+# -*- encoding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    This module copyright (C) 2014 Savoir-faire Linux
+#    (<http://www.savoirfairelinux.com>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openupgrade import openupgrade
+
+column_renames = {
+    'sale_order': [
+        ('categ_id', None),
+    ],
+}
+
+
[e-mail]()
+def migrate(cr, version):
+    openupgrade.rename_columns(cr, column_renames)