Merge lp:~savoirfairelinux-openerp/openobject-server/testfix-bug1206557 into lp:openobject-server/7.0
Status: | Needs review |
---|---|
Proposed branch: | lp:~savoirfairelinux-openerp/openobject-server/testfix-bug1206557 |
Merge into: | lp:openobject-server/7.0 |
Diff against target: |
46 lines (+8/-5) 2 files modified
openerp/addons/base/tests/test_base.py (+3/-3) openerp/addons/base/tests/test_expression.py (+5/-2) |
To merge this branch: | bzr merge lp:~savoirfairelinux-openerp/openobject-server/testfix-bug1206557 |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
OpenERP Core Team | Pending | ||
Review via email: mp+177624@code.launchpad.net |
Description of the change
When running the test suite for the "base" module, I get two failures.
The first one is about VAT validation. The dummy VAT numbers used are not valid Belgian VAT numbers and this causes a validation error which causes the test to wrongly fail. I've changed the VAT numbers to be valid ones
The second one is about bank accounts. The test creates dummy partner/bank relation and uses the first available bank type which, on my machine, happens to be the "iban" type. This type entails extra validation which make the test prematurely fail. I've made sure that the bank type used is the "bank" type.
Unmerged revisions
- 5040. By Virgil Dupras
-
[FIX] Fixed 2 tests in "base" test suite.
The first one is about VAT validation. The dummy VAT numbers used are not valid Belgian VAT numbers and this causes a validation error which causes the test to wrongly fail. I've changed the VAT numbers to be valid ones
The second one is about bank accounts. The test creates dummy partner/bank relation and uses the first available bank type which, on my machine, happens to be the "iban" type. This type entails extra validation which make the test prematurely fail. I've made sure that the bank type used is the "bank" type.