Merge lp:~savoirfairelinux-openerp/openobject-addons/7.0_mail_thread_translate_bug1262000 into lp:openobject-addons/7.0

[Sandy Carter (http://www.savoirfairelinux.com)]

Fix for bug #1262000 in which OEChatter's mail_thread widget does not translate the object's _description field resulting in half-translated messages posted in the mail thread.

Simple line change which translates self._description when invoked here.

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

Can someone review this, please.
It is a very simple fix for a pretty obvious translation bug.

[Martin Trigaux (OpenERP) (mat-openerp)]

Hello,

This may work for some models by some but _description is not translated by default. Fixing it this way will not be coherent. By luck you may have translation for res.groups but not others.
Without having a better solution (such as translating by default _description, which should be discussed), it's a limitation of the framework that we do no translate this.
In other models we use the subtypes (eg: project.task) which are translated.

Regards

review: Disapprove

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

@Martin
This was discussed in the ocb MP, the following MP for openobject-server guarentees that _description is exported in the translation files:

https://code.launchpad.net/~savoirfairelinux-openerp/openobject-server/7.0_mail_thread_translate_bug1262000/+merge/208812

Unmerged revisions

9702. By Sandy Carter (http://www.savoirfairelinux.com) on 2013-12-17

[FIX] Have object description translated when posting OEChatter 'created' message (Bug #1262000)

=== modified file 'mail/mail_thread.py'
--- mail/mail_thread.py	2013-12-09 09:09:03 +0000
+++ mail/mail_thread.py	2013-12-17 23:50:58 +0000
@@ -242,7 +242,7 @@
 
         # automatic logging unless asked not to (mainly for various testing purpose)
         if not context.get('mail_create_nolog'):
-            self.message_post(cr, uid, thread_id, body=_('%s created') % (self._description), context=context)
+            self.message_post(cr, uid, thread_id, body=_('%s created') % (_(self._description)), context=context)
 
         # subscribe uid unless asked not to
         if not context.get('mail_create_nosubscribe'):