Merge lp:~savoirfairelinux-openerp/openerp-mgmtsystem/nc_dep into lp:openerp-mgmtsystem

[Sandy Carter (http://www.savoirfairelinux.com)]

Reverts the nonconformities inheriting crm.claims unnecessarily from the nc-chatter-v7 merge.

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

review: Approve (code review)

[Daniel Reis (dreis-pt)]

In principle I agree with removing the dependency, but did you confirm the impact in the workflow?
It's because crm.claim provided a lot of logic for state changes, and it's possible that some behaviours rely on that dependency.

PS:
An idea to explore in a later MP is to add stages to the NCs and create a Kanban view. ideally it should work in a way very similar to Project Tasks or Issues.

review: Needs Information

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

I don't see any problems with the state changes.
The addition of crm.claim was a mistake on my part, I wasn't using its functionality.
crm.claim requires a field called name which is not currently provided. See https://bugs.launchpad.net/openerp-mgmtsystem/+bug/1233159

[Daniel Reis (dreis-pt)]

review: Approve (lgtm (no test))

=== modified file 'mgmtsystem_nonconformity/mgmtsystem_nonconformity.py'
--- mgmtsystem_nonconformity/mgmtsystem_nonconformity.py	2013-09-17 21:57:29 +0000
+++ mgmtsystem_nonconformity/mgmtsystem_nonconformity.py	2013-09-19 20:03:24 +0000
@@ -139,7 +139,7 @@
     _name = "mgmtsystem.nonconformity"
     _description = "Nonconformity of the management system"
     _rec_name = "description"
-    _inherit = ['crm.claim']
+    _inherit = ['mail.thread']
     _order = "date desc"
 
     def _state_name(self, cr, uid, ids, name, args, context=None):