Merge lp:~savoirfairelinux-openerp/openerp-isp/fix_unknown_dependancy_product_form into lp:openerp-isp

Proposed by Mathieu Benoit
Status: Merged
Merged at revision: 29
Proposed branch: lp:~savoirfairelinux-openerp/openerp-isp/fix_unknown_dependancy_product_form
Merge into: lp:openerp-isp
Diff against target: 11 lines (+0/-1)
1 file modified
product_dependencies/product.py (+0/-1)
To merge this branch: bzr merge lp:~savoirfairelinux-openerp/openerp-isp/fix_unknown_dependancy_product_form
Reviewer Review Type Date Requested Status
Joao Alfredo Gama Batista code review, no tests Approve
Pedro Manuel Baeza code review Approve
Sandy Carter (http://www.savoirfairelinux.com) Approve
Review via email: mp+220709@code.launchpad.net

Description of the change

Remove duplicate field product_id in product_dependency to fix the unknown label product in dependancy form.

To post a comment you must log in.
Revision history for this message
Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote :

LGTM

review: Approve
Revision history for this message
Pedro Manuel Baeza (pedro.baeza) wrote :

LGTM. Thanks.

review: Approve (code review)
Revision history for this message
Joao Alfredo Gama Batista (joao-gama) wrote :

LGTM.

BTW. I'm so embarassed!! :o

review: Approve (code review, no tests)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'product_dependencies/product.py'
2--- product_dependencies/product.py 2013-09-16 17:59:01 +0000
3+++ product_dependencies/product.py 2014-05-22 19:23:39 +0000
4@@ -36,7 +36,6 @@
5 'category_id': fields.many2one('product.category',
6 string='Category Dependency'),
7 'auto': fields.boolean('Automatically added'),
8- 'product_id': fields.many2one('product.product')
9 }
10
11 _defaults = {

Subscribers

People subscribed via source and target branches