Code review comment for lp:~savoirfairelinux-openerp/openerp-hr/unique_code

Revision history for this message
Daniel Reis (dreis-pt) wrote :

Hello Sandy,

Since you're at it, you could also add the generic .pot file, to make this translatable.

Also, I wouldn't like to have the "name_get" changes here.
I suggest that to be a separate module, so that people can choose to use it or not.
And it should implement that both on "name_get" and "name_search".

I did an implementation for that, and use it in production, doing that both for Departments and Employees. See the "hr_refcodes" ad https://code.launchpad.net/~dreis-pt/reis-openerp-addons/7.0
Arguably, it could be split in two modules.
(And you can find there also modules to display/search Customer and Contract codes).

review: Needs Fixing

« Back to merge proposal