Code review comment for lp:~savoirfairelinux-openerp/openerp-hr/hr_employee_firstname

Revision history for this message
Daniel Reis (dreis-pt) wrote :

Thanks for the contribution. Comments:

L64: shouldn't the Category be "Human Resources" instead of MISC?
L86: why is the module declares inactive?
L126: the SQL uses a "name_related" field. I'm not aware of it in standard HR modules. Are you sure this is ok?; also, you're missing a blank line after the method (PEP8).

review: Needs Information

« Back to merge proposal