Code review comment for lp:~savoirfairelinux-openerp/openerp-hr/experience
Revision history for this message
| Joao Alfredo Gama Batista (joao-gama) wrote | # |
review:
Needs Fixing
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
67d34a1
(Get the code!)
Hi El Hadji,
Thanks for your contribution. As for the review I have this 2 points that you can improve.
l.100.103.132: Even in 6.1 the osv is considered deprecated (osv.osv actually points to orm.Model) so for the import is better to use "from openerp.osv import orm, fields" and for the models it's better to inherit from orm.Model istead of osv.osv.
l.129.137: In 6.1 we don't need to instantiate the model after defining it.