Merge lp:~savoirfairelinux-openerp/openerp-hr/7.0-language into lp:openerp-hr

[El Hadji Dem (http://www.savoirfairelinux.com)]

[ADD] add hr_skill module

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

Thanks El Hadji.

Please remove line 117 and 125. They are not required on version 7.

Otherwise LGTM.

review: Needs Fixing (code review)

[lp:~savoirfairelinux-openerp/openerp-hr/7.0-language]

69. By EL HADJI DEM <email address hidden> on 2013-11-14

[IMP] fix the copyright and update to reflect the new fields and views

70. By EL HADJI DEM <email address hidden> on 2013-11-14

[IMP] don't need to instantiate a class in 7.0

[Daniel Reis (dreis-pt)]

Why employee languages are in free text instead of pointing to a isn't a languages table?
How do I have a reliable way to list who knows a certain language?

Read/Write/Speak shouldn't be a boolean, it should be a selection.
The Europass CV model proposes 6 levels: http://europass.cedefop.europa.eu/en/resources/european-language-levels-cefr
(For information, some Europass CV examples: http://europass.cedefop.europa.eu/en/documents/curriculum-vitae/examples)

Wouldn't "Languages" be better of if it could be fit as Skills?

review: Needs Information

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

Hello Daniel,

Employee language does not point to the language table, because an employee may speak languages that are not installed on OpenERP. That's why we are using the language list from the base module.

Regarding the type, nobody is using those levels here in North America. It looks very specific to Europe. I tend to stick to a simpler approach. Would the list from LinkedIn be suitable for each of those 3 fields:

Notions
Limited professional skill
Professional skill
Full professional skill
Bilingual or mother tongue

If we want to have a drop down list, it would not fit. With languages, we also make sure to have the read, write and speak information. If they were in skills, you could add one (written english) and forget to choose the other 2 (spoken english and read english).

[Daniel Reis (dreis-pt)]

Maxime,

I mentioned the Europass just as an example. It's useful to keep in mind we might want to extend the module to support that. The LinkedIn proficiency levels are an excellent reference.
And I personally think that keeping Read/Write/Speak proficiencies is an overkill.

In theory, Languages should go alongside other skills, but it practice that probably isn't practical for most common use cases.
So I can see this as base employee language support, and let more sofisticated Skill modules change that for the implementations that really need it.

So, I'm OK with the design choices.
Setting to "Needs Fixing" only because the pot file is missing.

review: Needs Fixing

[lp:~savoirfairelinux-openerp/openerp-hr/7.0-language]

71. By EL HADJI DEM <email address hidden> on 2013-11-14

[IMP] add pot file

72. By EL HADJI DEM <email address hidden> on 2013-11-15

[IMP] add pot file

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

review: Approve (code review)

[Daniel Reis (dreis-pt)]

review: Approve

=== added directory 'hr_language'
=== added file 'hr_language/__init__.py'
--- hr_language/__init__.py	1970-01-01 00:00:00 +0000
+++ hr_language/__init__.py	2013-11-15 14:19:14 +0000
@@ -0,0 +1,22 @@
+# -*- encoding: utf-8 -*-
+###############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2013 Savoir-faire Linux (<http://www.savoirfairelinux.com>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+import hr_language
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'hr_language/__openerp__.py'
--- hr_language/__openerp__.py	1970-01-01 00:00:00 +0000
+++ hr_language/__openerp__.py	2013-11-15 14:19:14 +0000
@@ -0,0 +1,42 @@
+# -*- encoding: utf-8 -*-
+###############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2013 Savoir-faire Linux (<http://www.savoirfairelinux.com>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+
+{
+    "name": "Language Management",
+    "version": "0.1",
+    "category": "Human Resources",
+    "license": "AGPL-3",
+    "description": """
+    This module allows you to manage your employee languages.
+    """,
+    "author": "Savoir-faire Linux",
+    "website": "http://www.savoirfairelinux.com",
+    "depends": ["hr"],
+    'data': ["security/ir.model.access.csv",
+             "hr_language_view.xml",
+             ],
+    "demo": [],
+    "test": [],
+    "installable": True,
+    "auto_install": False,
+    "images": [],
+}
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'hr_language/hr_language.py'
--- hr_language/hr_language.py	1970-01-01 00:00:00 +0000
+++ hr_language/hr_language.py	2013-11-15 14:19:14 +0000
@@ -0,0 +1,47 @@
+# -*- encoding: utf-8 -*-
+###############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2013 Savoir-faire Linux (<http://www.savoirfairelinux.com>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program. If not, see <http://www.gnu.org/licenses/>.
+#
+###############################################################################
+import tools
+from openerp.osv import fields, orm
+
+class hr_language(orm.Model):
+    _name = 'hr.language'
+    _columns = {
+        'name': fields.selection(tools.scan_languages(), 'Language', required=True),
+        'description': fields.char('Description', size=64, required=True, translate=True),
+        'employee_id': fields.many2one('hr.employee', 'Employee', required=True),
+        'read': fields.boolean('Read'),
+        'write': fields.boolean('Write'),
+        'speak': fields.boolean('Speak'),
+    }
+
+    _defaults = {
+        'read': True,
+        'write': True,
+        'speak': True,
+    }
+
+class hr_employee(orm.Model):
+    _inherit = 'hr.employee'
+    _columns = {
+        'language_ids': fields.one2many('hr.language', 'employee_id', 'Languages'),
+    }
+
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:

=== added file 'hr_language/hr_language_view.xml'
--- hr_language/hr_language_view.xml	1970-01-01 00:00:00 +0000
+++ hr_language/hr_language_view.xml	2013-11-15 14:19:14 +0000
@@ -0,0 +1,65 @@
+<openerp>
+  <data>
+    <!-- Employee -->
+    <record model="ir.ui.view" id="view_employee_form">
+        <field name="name">hr.language.employee.form</field>
+        <field name="model">hr.employee</field>
+        <field name="inherit_id" ref="hr.view_employee_form"/>
+        <field name="type">form</field>
+        <field name="arch" type="xml">
+            <notebook position="inside">
+                <page string="Languages">
+                    <field name="language_ids" nolabel="1" colspan="4"/>
+                </page>
+            </notebook>
+        </field>
+    </record>
+
+    <!-- Language -->
+
+    <record model="ir.ui.view" id="view_language_tree">
+        <field name="name">hr.language.tree</field>
+        <field name="model">hr.language</field>
+        <field name="type">tree</field>
+        <field name="arch" type="xml">
+            <tree string="Languages">
+                <field name="description"/>
+                <field name="read"/>
+                <field name="write"/>
+                <field name="speak"/>
+            </tree>
+        </field>
+    </record>
+
+    <record model="ir.ui.view" id="view_language_form">
+        <field name="name">hr.language.form</field>
+        <field name="model">hr.language</field>
+        <field name="type">form</field>
+        <field name="arch" type="xml">
+            <form string="Language">
+                <field name="name"/>
+                <field name="description"/>
+                <field name="employee_id"/>
+                <newline/>
+                <field name="read"/>
+                <newline/>
+                <field name="write"/>
+                <newline/>
+                <field name="speak"/>
+            </form>
+        </field>
+    </record>
+
+    <record model="ir.actions.act_window" id="open_view_language_form">
+        <field name="res_model">hr.language</field>
+        <field name="view_type">form</field>
+        <field name="view_mode">tree,form</field>
+    </record>
+
+    <menuitem name="Languages"
+              parent="hr.menu_hr_configuration"
+              id="menu_open_view_language_form"
+              action="open_view_language_form"/>
+
+  </data>
+</openerp>

=== added directory 'hr_language/i18n'
=== added file 'hr_language/i18n/hr_language.pot'
--- hr_language/i18n/hr_language.pot	1970-01-01 00:00:00 +0000
+++ hr_language/i18n/hr_language.pot	2013-11-15 14:19:14 +0000
@@ -0,0 +1,462 @@
+# Translation of OpenERP Server.
+# This file contains the translation of the following modules:
+#	* hr_language
+#
+msgid ""
+msgstr ""
+"Project-Id-Version: OpenERP Server 7.0\n"
+"Report-Msgid-Bugs-To: \n"
+"POT-Creation-Date: 2013-11-14 22:04+0000\n"
+"PO-Revision-Date: 2013-11-14 22:04+0000\n"
+"Last-Translator: <>\n"
+"Language-Team: \n"
+"MIME-Version: 1.0\n"
+"Content-Type: text/plain; charset=UTF-8\n"
+"Content-Transfer-Encoding: \n"
+"Plural-Forms: \n"
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Croatian / hrvatski jezik"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "English (CA)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Romanian / română"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Albanian / Shqip"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Hebrew / עִבְרִי"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Sinhalese / සිංහල"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (EC) / Español (EC)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (PR) / Español (PR)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Hungarian / Magyar"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Telugu / తెలుగు"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (VE) / Español (VE)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Lithuanian / Lietuvių kalba"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Bulgarian / български език"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Portuguese (BR) / Português (BR)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (UY) / Español (UY)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Danish / Dansk"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (BO) / Español (BO)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Korean (KR) / 한국어 (KR)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (PE) / Español (PE)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "French (CH) / Français (CH)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Arabic / الْعَرَبيّة"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Abkhazian / аҧсуа"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (CO) / Español (CO)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Czech / Čeština"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Gujarati / ગુજરાતી"
+msgstr ""
+
+#. module: hr_language
+#: field:hr.language,employee_id:0
+#: model:ir.model,name:hr_language.model_hr_employee
+msgid "Employee"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Inuktitut / ᐃᓄᒃᑎᑐᑦ"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Galician / Galego"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Klingon"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (PY) / Español (PY)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Urdu / اردو"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Catalan / Català"
+msgstr ""
+
+#. module: hr_language
+#: model:ir.model,name:hr_language.model_hr_language
+msgid "hr.language"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Serbian (Cyrillic) / српски"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Flemish (BE) / Vlaams (BE)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Portuguese / Português"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish / Español"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Chinese (TW) / 正體字"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Korean (KP) / 한국어 (KP)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (SV) / Español (SV)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Ukrainian / українська"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (AR) / Español (AR)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Chinese (HK)"
+msgstr ""
+
+#. module: hr_language
+#: field:hr.language,speak:0
+msgid "Speak"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (GT) / Español (GT)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Indonesian / Bahasa Indonesia"
+msgstr ""
+
+#. module: hr_language
+#: view:hr.employee:0
+#: field:hr.employee,language_ids:0
+#: view:hr.language:0
+#: model:ir.ui.menu,name:hr_language.menu_open_view_language_form
+msgid "Languages"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (PA) / Español (PA)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Vietnamese / Tiếng Việt"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Slovak / Slovenský jazyk"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Amharic / አምሃርኛ"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Latvian / latviešu valoda"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (CL) / Español (CL)"
+msgstr ""
+
+#. module: hr_language
+#: view:hr.language:0
+#: field:hr.language,name:0
+msgid "Language"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Italian / Italiano"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Bosnian / bosanski jezik"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (DO) / Español (DO)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Norwegian Bokmål / Norsk bokmål"
+msgstr ""
+
+#. module: hr_language
+#: field:hr.language,write:0
+msgid "Write"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Finnish / Suomi"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "German / Deutsch"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (MX) / Español (MX)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "French / Français"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Greek / Ελληνικά"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Estonian / Eesti keel"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Dutch / Nederlands"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Turkish / Türkçe"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Serbian (Latin) / srpski"
+msgstr ""
+
+#. module: hr_language
+#: field:hr.language,description:0
+msgid "Description"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (CR) / Español (CR)"
+msgstr ""
+
+#. module: hr_language
+#: field:hr.language,read:0
+msgid "Read"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "English (US)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Occitan (FR, post 1500) / Occitan"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (HN) / Español (HN)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Hindi / हिंदी"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Mongolian / монгол"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Spanish (NI) / Español (NI)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Malayalam / മലയാളം"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "French (BE) / Français (BE)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Thai / ภาษาไทย"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Slovenian / slovenščina"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Persian / فارس"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Polish / Język polski"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Swedish / svenska"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Chinese (CN) / 简体中文"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "English (UK)"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Japanese / 日本語"
+msgstr ""
+
+#. module: hr_language
+#: selection:hr.language,name:0
+msgid "Russian / русский язык"
+msgstr ""
+

=== added directory 'hr_language/security'
=== added file 'hr_language/security/ir.model.access.csv'
--- hr_language/security/ir.model.access.csv	1970-01-01 00:00:00 +0000
+++ hr_language/security/ir.model.access.csv	2013-11-15 14:19:14 +0000
@@ -0,0 +1,2 @@
+"id","name","model_id:id","group_id:id","perm_read","perm_write","perm_create","perm_unlink"
+"access_hr_language","hr.language","model_hr_language",base.group_hr_user,1,1,1,1