Code review comment for lp:~savoirfairelinux-openerp/ocb-server/translate_warnings_1297525-trunk

Revision history for this message
Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter) wrote :

It would make the tests fail, but this problem is widespread in OE.
For example test_20_message_post (openerp.addons.mail.tests.test_mail_features.test_mail) fails when a translator changes the value. It just doesn't fail in en_US because the values haven't changed. The same is not true for other locales.

A solution to this would be to use _() in the assert. I am not sure if that's possible in yml.

If we're talking about changing en_US why not revert my last commit and translate "ValidateError" as "Validate Error"?

« Back to merge proposal