Merge lp:~savoirfairelinux-openerp/lp-community-utils/progressbar into lp:lp-community-utils

[Sandy Carter (http://www.savoirfairelinux.com)]

Adds a progressbar in the console output since this script takes a long time.
The progressbar is from the progressbar library. If it is available, it will offer it, otherwise, it will go on as before.

[Pedro Manuel Baeza (pedro.baeza)]

It doesn't work with the version included in Ubuntu 12.04 (python-progressbar 2.2-2), but it does with the one got with pip. It says:

"'ProgressBar' object is not callable"

Do you know what can be happening?

Regards.

review: Needs Information

[Sandy Carter (http://www.savoirfairelinux.com) (sandy-carter)]

I didn't test with version 2.2, I assumed it would work.
What version do you have with pip?

The version I used (I have Arch, not Ubuntu) is 2.3.

This is the base usage of progressbar (from their documentation)
progress = ProgressBar()
for i in progress(range(80)):
  time.sleep(0.01)

The problematic call would be progress(...)

Maybe this is a functionality introduced by 2.3

[lp:~savoirfairelinux-openerp/lp-community-utils/progressbar]

25. By Sandy Carter (http://www.savoirfairelinux.com) on 2014-02-06

Made progressbar=2.2 compatible

[Pedro Manuel Baeza (pedro.baeza)]

Hi, Sandy,

Now, it works well with both versions.

Thank you very much.

Regards.

review: Approve (code review and test)

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

review: Approve

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

Nice!
Thanks

review: Approve

=== modified file 'README.rst'
--- README.rst	2013-09-22 14:36:16 +0000
+++ README.rst	2014-02-06 21:02:36 +0000
@@ -8,6 +8,7 @@
 Other versions of Python have not been tested.
 
 The launchpadlib_ egg is required.
+The progressbar_ library is optional but allows to display progress
 
 Usage
 -----
@@ -61,5 +62,6 @@
 
 
 .. _launchpadlib: http://pypi.python.org/pypi/launchpadlib/1.10.2
+.. _progressbar: https://pypi.python.org/pypi/progressbar/2.2
 .. _lazr.restfulclient: https://launchpad.net/lazr.restfulclient
 .. _lazr.restfulclient bug report: https://bugs.launchpad.net/lazr.restfulclient/+bug/1094253

=== modified file 'openerp-nag'
--- openerp-nag	2013-09-22 14:36:16 +0000
+++ openerp-nag	2014-02-06 21:02:36 +0000
@@ -46,6 +46,10 @@
 import datetime
 import logging
 
+try:
+    from progressbar import ProgressBar, Bar, Percentage, ETA
+except ImportError:
+    ProgressBar = None
 from launchpadlib.launchpad import Launchpad
 
 
@@ -227,9 +231,18 @@
 
     # Find things to nag about
     nags = []
+    if ProgressBar:
+        widgets = ["Looking for things to nag about... ", Percentage(), 
+                   Bar(left=" [", right="] "), ETA()]
+        progress = ProgressBar(widgets=widgets, maxval=len(project_names)).start()
     for project_name in project_names:
         logging.info("Looking for things to nag about under %s", project_name)
         nags.extend(gen_project_nags(lp, policy, project_name))
+        if ProgressBar:
+            progress.update(progress.currval + 1)
+    if ProgressBar:
+        progress.finish()
+
     nags.sort(key=lambda nag: (nag.sort_class, nag.sort_priority,
                                nag.sort_age))
     print("=" * 80)