Code review comment for lp:~savoirfairelinux-openerp/account-invoicing/account_invoice_line_merge

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

I think the problem Joël means is that the sale_origin addon simply contains the code for purchase_origin.

Then for #344ff: I think it's a bad idea to copy the original function and break inheritance. Better call super and set the origin field in the dictionary you get back.

review: Needs Fixing

« Back to merge proposal