Merge lp:~saviq/unity8/shared-gestures into lp:unity8

Proposed by Michał Sawicz on 2016-03-31
Status: Rejected
Rejected by: Michał Sawicz on 2016-03-31
Proposed branch: lp:~saviq/unity8/shared-gestures
Merge into: lp:unity8
Diff against target: 12 lines (+1/-1)
1 file modified
plugins/Ubuntu/Gestures/CMakeLists.txt (+1/-1)
To merge this branch: bzr merge lp:~saviq/unity8/shared-gestures
Reviewer Review Type Date Requested Status
Unity8 CI Bot continuous-integration Needs Fixing on 2016-03-31
Michał Sawicz Disapprove on 2016-03-31
Review via email: mp+290633@code.launchpad.net

Commit message

Make UbuntuGestures SHARED

Tests link to it and otherwise it exports no symbols

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
N/A
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Britney will
 * Did you make sure that your branch does not contain spurious tags?
Y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Y
 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Michał Sawicz (saviq) wrote :

Nope.

review: Disapprove
Unity8 CI Bot (unity8-ci-bot) wrote :

FAILED: Continuous integration, rev:2314
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/908/
Executed test runs:
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=vivid+overlay,testname=qmluitests.sh/490
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=amd64,release=xenial,testname=qmluitests.sh/490
    UNSTABLE: https://unity8-jenkins.ubuntu.com/job/test-0-autopkgtest/label=phone-armhf,release=vivid+overlay,testname=autopilot.sh/490
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-0-fetch/1219
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=vivid+overlay/1195
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-1-sourcepkg/release=xenial/1195
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1193
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=vivid+overlay/1193/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1193
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=amd64,release=xenial/1193/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1193
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=vivid+overlay/1193/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1193
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=armhf,release=xenial/1193/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1193
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=vivid+overlay/1193/artifact/output/*zip*/output.zip
    SUCCESS: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1193
        deb: https://unity8-jenkins.ubuntu.com/job/build-2-binpkg/arch=i386,release=xenial/1193/artifact/output/*zip*/output.zip

Click here to trigger a rebuild:
https://unity8-jenkins.ubuntu.com/job/lp-unity8-ci/908/rebuild

review: Needs Fixing (continuous-integration)

Unmerged revisions

2314. By Michał Sawicz on 2016-03-31

Make UbuntuGestures SHARED

Tests link to it and otherwise it exports no symbols

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'plugins/Ubuntu/Gestures/CMakeLists.txt'
2--- plugins/Ubuntu/Gestures/CMakeLists.txt 2016-03-11 20:18:12 +0000
3+++ plugins/Ubuntu/Gestures/CMakeLists.txt 2016-03-31 16:44:39 +0000
4@@ -16,7 +16,7 @@
5
6 add_definitions(-DUBUNTUGESTURESQML_LIBRARY)
7
8-add_library(UbuntuGesturesQml MODULE ${UbuntuGesturesQml_SOURCES})
9+add_library(UbuntuGesturesQml SHARED ${UbuntuGesturesQml_SOURCES})
10 target_link_libraries(UbuntuGesturesQml UbuntuGestures)
11
12 qt5_use_modules(UbuntuGesturesQml Core Quick)

Subscribers

People subscribed via source and target branches