Merge lp:~saviq/unity8/qt-renames-no-dee into lp:unity8

Proposed by Michał Sawicz
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 859
Merged at revision: 880
Proposed branch: lp:~saviq/unity8/qt-renames-no-dee
Merge into: lp:unity8
Prerequisite: lp:~saviq/unity8/split-common
Diff against target: 56 lines (+5/-7)
2 files modified
build (+1/-2)
debian/control (+4/-5)
To merge this branch: bzr merge lp:~saviq/unity8/qt-renames-no-dee
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
Timo Jyrinki Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+217444@code.launchpad.net

This proposal supersedes a proposal from 2014-04-28.

Commit message

Adapt to Debian Qt package renames and drop unneeded Dee plugin dependency.

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
New qtdeclarative needs to land.

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.

 * Did you make sure that your branch does not contain spurious tags?
Yes.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Yes.

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

Text conflict in debian/control
1 conflicts encountered.

review: Needs Fixing
lp:~saviq/unity8/qt-renames-no-dee updated
858. By Michał Sawicz

Merge trunk.

Revision history for this message
Michał Sawicz (saviq) wrote :

Merged.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
lp:~saviq/unity8/qt-renames-no-dee updated
859. By Michał Sawicz

Undo qtmultimedia rename, not there yet.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Looks good now as the qtmultimedia one is not yet in archives indeed!

review: Approve
Revision history for this message
Albert Astals Cid (aacid) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes, still builds

 * Did CI run pass? If not, please explain why.
No, it's using trusty instead of utopic

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'build'
2--- build 2014-04-02 12:08:51 +0000
3+++ build 2014-04-30 10:42:12 +0000
4@@ -43,13 +43,12 @@
5 gsettings-desktop-schemas \
6 gsettings-ubuntu-schemas \
7 qmenumodel-qml \
8- qtdeclarative5-dee-plugin \
9+ qml-module-qtquick-xmllistmodel \
10 qtdeclarative5-gsettings1.0 \
11 qtdeclarative5-ubuntu-ui-toolkit-plugin \
12 qtdeclarative5-ubuntu-settings-components \
13 qtdeclarative5-ubuntu-thumbnailer0.1 \
14 unity-notifications-impl \
15- qtdeclarative5-xmllistmodel-plugin \
16 ubuntu-mobile-icons \
17 unity-scope-home \
18 unity-lens-applications \
19
20=== modified file 'debian/control'
21--- debian/control 2014-04-29 15:08:05 +0000
22+++ debian/control 2014-04-30 10:42:12 +0000
23@@ -26,6 +26,9 @@
24 python3-all:any,
25 python3-setuptools,
26 python:any (>= 2.7),
27+ qml-module-qtquick-xmllistmodel,
28+ qml-module-qtquick2,
29+ qml-module-qttest,
30 qt5-default,
31 qtbase5-dev,
32 qtbase5-dev-tools,
33@@ -34,11 +37,8 @@
34 qtdeclarative5-dev-tools,
35 qtdeclarative5-private-dev,
36 qtdeclarative5-qtmultimedia-plugin,
37- qtdeclarative5-qtquick2-plugin,
38- qtdeclarative5-test-plugin,
39 qtdeclarative5-ubuntu-settings-components,
40 qtdeclarative5-ubuntu-ui-toolkit-plugin,
41- qtdeclarative5-xmllistmodel-plugin,
42 ttf-ubuntu-font-family,
43 Standards-Version: 3.9.4
44 Homepage: http://launchpad.net/unity
45@@ -76,10 +76,9 @@
46 libglib2.0-bin,
47 libunity-mir1 (>= 0.4),
48 qmenumodel-qml (>= 0.2.7),
49- qtdeclarative5-dee-plugin,
50+ qml-module-qtquick-xmllistmodel,
51 qtdeclarative5-gsettings1.0,
52 qtdeclarative5-ubuntu-settings-components,
53- qtdeclarative5-xmllistmodel-plugin,
54 unity-launcher-impl-3,
55 unity8-common (= ${source:Version}),
56 unity8-private (= ${binary:Version}),

Subscribers

People subscribed via source and target branches