Merge lp:~saviq/unity8/preview-overview into lp:unity8

[Michał Sawicz]

Support previews for scopes in overview and hook up preview processing to activity indicator.

 * Are there any related MPs required for this MP to build/function as expected? Please list.
No.

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.

 * Did you make sure that your branch does not contain spurious tags?
Yes.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

[PS Jenkins bot (ps-jenkins)]

FAILED: Continuous integration, rev:1161
http://jenkins.qa.ubuntu.com/job/unity8-ci/3917/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-utopic-touch/3579/console
    UNSTABLE: http://jenkins.qa.ubuntu.com/job/unity-phablet-qmluitests-utopic/918
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-amd64-ci/1011
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/1011
        deb: http://jenkins.qa.ubuntu.com/job/unity8-utopic-armhf-ci/1011/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity8-utopic-i386-ci/1011
    FAILURE: http://jenkins.qa.ubuntu.com/job/generic-deb-autopilot-runner-mako/3472/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4826
        deb: http://jenkins.qa.ubuntu.com/job/generic-mediumtests-builder-utopic-armhf/4826/artifact/work/output/*zip*/output.zip
    SUCCESS: http://s-jenkins.ubuntu-ci:8080/job/touch-flash-device/11519

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity8-ci/3917/rebuild

review: Needs Fixing (continuous-integration)

[Mirco Müller (macslow)]

See inline comment.

review: Needs Fixing

[Michał Sawicz (saviq)]

> What should currentIndex be, -1 or index?:)

This is basically forcing the ListView to do what we need by resetting
it to invalid and then back to the real thing.

[Michał Sawicz (saviq)]

Sorry... it's already in silo and the only concern was explained :/

review: Approve

=== modified file 'qml/Dash/ScopesOverview.qml'
--- qml/Dash/ScopesOverview.qml	2014-08-11 19:02:29 +0000
+++ qml/Dash/ScopesOverview.qml	2014-08-14 22:20:19 +0000
@@ -32,7 +32,7 @@
     property alias currentTab: tabBar.currentTab
 
     // Properties used by parent
-    readonly property bool processing: searchResultsViewer.processing || tempScopeItem.processing
+    readonly property bool processing: searchResultsViewer.processing || tempScopeItem.processing || previewListView.processing
     property bool growingDashFromPos: false
     readonly property bool searching: scope && scope.searchQuery == ""
     readonly property bool showingNonFavoriteScope: tempScopeItem.scope != null
@@ -366,7 +366,16 @@
             }
 
             function itemPressedAndHeld(index, itemModel, resultsModel, limitedCategoryItemCount) {
-                // Do nothing
+                if (itemModel.uri.indexOf("scope://") === 0) {
+                    // Preview can call openScope so make sure restorePosition and restoreSize are set
+                    scopesOverviewXYScaler.restorePosition = undefined;
+                    scopesOverviewXYScaler.restoreSize = allCardSize;
+
+                    previewListView.model = resultsModel;
+                    previewListView.currentIndex = -1;
+                    previewListView.currentIndex = index;
+                    previewListView.open = true;
+                }
             }
         }
 
@@ -455,8 +464,6 @@
         anchors.left: scopesOverviewContent.right
     }
 
-
-
     Item {
         id: scopesOverviewXYScaler
         width: parent.width