Merge lp:~saviq/unity8/no-sigstop-main into lp:unity8

Proposed by Michał Sawicz on 2015-01-07
Status: Merged
Approved by: Michael Zanetti on 2015-01-07
Approved revision: 1524
Merged at revision: 1532
Proposed branch: lp:~saviq/unity8/no-sigstop-main
Merge into: lp:unity8
Diff against target: 16 lines (+0/-6)
1 file modified
src/main.cpp (+0/-6)
To merge this branch: bzr merge lp:~saviq/unity8/no-sigstop-main
Reviewer Review Type Date Requested Status
Michael Zanetti (community) 2015-01-07 Approve on 2015-01-07
Review via email: mp+245758@code.launchpad.net

Commit Message

We don't need the SIGSTOP in main() any more.

Description of the Change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
N
 * Did you perform an exploratory manual test run of your code change and any related functionality?
Y
 * Did you make sure that your branch does not contain spurious tags?
Y
 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A
 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Michael Zanetti (mzanetti) wrote :

yip yip..

 * Did you perform an exploratory manual test run of the code change and any related functionality?

yes

 * Did CI run pass? If not, please explain why.

not yet

 * Did you make sure that the branch does not contain spurious tags?

yes

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/main.cpp'
2--- src/main.cpp 2014-10-01 13:20:32 +0000
3+++ src/main.cpp 2015-01-07 15:57:34 +0000
4@@ -147,12 +147,6 @@
5 view->setSource(source);
6 QObject::connect(view->engine(), SIGNAL(quit()), application, SLOT(quit()));
7
8- if (!isMirServer && qEnvironmentVariableIsSet("UNITY_MIR_EMITS_SIGSTOP")) {
9- // Emit SIGSTOP as expected by upstart, under Mir it's qtmir that will raise it.
10- // see http://upstart.ubuntu.com/cookbook/#expect-stop
11- raise(SIGSTOP);
12- }
13-
14 if (isMirServer || parser.isSet(fullscreenOption)) {
15 view->showFullScreen();
16 } else {

Subscribers

People subscribed via source and target branches