Merge lp:~saviq/unity8/move-upstart-timeout into lp:unity8
Proposed by
Michał Sawicz
| Status: | Merged |
|---|---|
| Approved by: | Albert Astals Cid |
| Approved revision: | 642 |
| Merged at revision: | 683 |
| Proposed branch: | lp:~saviq/unity8/move-upstart-timeout |
| Merge into: | lp:unity8 |
| Diff against target: |
25 lines (+2/-2) 3 files modified
data/unity8.conf (+2/-0) data/unity8.override (+0/-1) debian/unity8-autopilot.install (+0/-1) |
| To merge this branch: | bzr merge lp:~saviq/unity8/move-upstart-timeout |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Albert Astals Cid (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Needs Fixing | |
| Didier Roche-Tolomelli | Approve | ||
|
Review via email:
|
|||
Commit message
Move upstart kill timeout to the unity8 job itself.
Description of the change
* Are there any related MPs required for this MP to build/function as expected? Please list.
No.
* Did you perform an exploratory manual test run of your code change and any related functionality?
Yes. Works as expected.
* If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
Yes. Didrocks reviewed already.
* If you changed the UI, has there been a design review?
N/A
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Full stacktraces, what a luxury! \o/
for some context:
07:47:17 Saviq | didrocks, so what I'm actually thinking is moving it to unity8 itself
07:47:32 didrocks | Saviq: yeah, I think it's making sense
07:47:38 Saviq | didrocks, as it only ever changes things when you go "initctl unity8 stop"
07:47:39 didrocks | I was about to suggest the same :)
07:48:05 Saviq | which normal users won't do, and if it crashes runtime, it will wait for apport to complete anyway
07:48:11 didrocks | exactly