Merge lp:~saviq/unity8/fix-run-upstart-env into lp:unity8

Proposed by Michał Sawicz
Status: Merged
Approved by: Albert Astals Cid
Approved revision: 855
Merged at revision: 876
Proposed branch: lp:~saviq/unity8/fix-run-upstart-env
Merge into: lp:unity8
Diff against target: 11 lines (+1/-1)
1 file modified
run (+1/-1)
To merge this branch: bzr merge lp:~saviq/unity8/fix-run-upstart-env
Reviewer Review Type Date Requested Status
Albert Astals Cid (community) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+217080@code.launchpad.net

Commit message

Pass env variables to initctl start.

Description of the change

 * Are there any related MPs required for this MP to build/function as expected? Please list.
N/A

 * Did you perform an exploratory manual test run of your code change and any related functionality?
Yes.

 * Did you make sure that your branch does not contain spurious tags?
Yes.

 * If you changed the packaging (debian), did you subscribe the ubuntu-unity team to this MP?
N/A

 * If you changed the UI, has there been a design review?
N/A

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :
review: Needs Fixing (continuous-integration)
Revision history for this message
Albert Astals Cid (aacid) wrote :

 * Did you perform an exploratory manual test run of the code change and any related functionality?
Yes, ./run -k works again

 * Did CI run pass? If not, please explain why.
Known listviewwithpageheaderqml error

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'run'
2--- run 2014-04-14 08:39:52 +0000
3+++ run 2014-04-24 15:59:21 +0000
4@@ -84,6 +84,6 @@
5 echo "Unity8 is already running, please stop it first"
6 exit 1
7 fi
8- /sbin/initctl start unity8 BINARY="`readlink -f $QML_PHONE_SHELL_PATH` $QML_PHONE_SHELL_ARGS $@"
9+ /sbin/initctl start unity8 BINARY="`readlink -f $QML_PHONE_SHELL_PATH` $QML_PHONE_SHELL_ARGS $@" QML2_IMPORT_PATH=$QML2_IMPORT_PATH LD_LIBRARY_PATH=$LD_LIBRARY_PATH
10 tailf -n 0 ~/.cache/upstart/unity8.log
11 fi

Subscribers

People subscribed via source and target branches